[dynamo] fix prim lowering validation logic for dynamic shape args #111208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111208
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 073496e with merge base 918054f ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
jon-chuang
commented
Oct 13, 2023
| @@ -1104,17 +1104,11 @@ def is_weakly_lesser_type(a: type, b: type) -> bool: | |||
|
|
|||
| The comparison is determined by the following type ordering: bool, int, float, complex. | |||
| """ | |||
| ordered_types = ( | |||
There was a problem hiding this comment.
duplicate global defined above
|
@pytorchbot label "topic: not user facing" |
0df4e39 to
d7e2046
Compare
jon-chuang
commented
Oct 13, 2023
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #111199
Fixes #111203
cc @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov @kadeng @ezyang