8000 Fix Android publish step with lite interpreter by huydhn · Pull Request #111071 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Fix Android publish step with lite interpreter #111071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix Android publish step with lite interpreter #111071

wants to merge 1 commit into from

Conversation

huydhn
Copy link
Contributor
@huydhn huydhn commented Oct 11, 2023

This file needs to be added to the list like others. The publish command BUILD_LITE_INTERPRETER=1 android/gradlew -p android publish finishes successfully with this and files are available on Nexus:

Screenshot 2023-10-11 at 11 56 53

@huydhn huydhn requested review from atalman and a team October 11, 2023 19:01
@pytorch-bot
Copy link
pytorch-bot bot commented Oct 11, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/111071

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 512077d with merge base 2edc75a (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions
Copy link
Contributor

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@huydhn
Copy link
Contributor Author
huydhn commented Oct 11, 2023

@pytorchbot merge -f 'Simple fix, Android build jobs have passed'

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Please use -f as last resort and instead consider -i/--ignore-current to continue the merge ignoring current failures. This will allow currently pending tests to finish and report signal before the merge.

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

huydhn added a commit to huydhn/pytorch that referenced this pull request Oct 11, 2023
@huydhn
Fix Android publish step with lite interpreter (pytorch#111071)
8427040 
This file needs to be added to the list like others.  The publish command `BUILD_LITE_INTERPRETER=1 android/gradlew -p android publish` finishes successfully with this and files are available on Nexus:

![Screenshot 2023-10-11 at 11 56 53](https://github.com/pytorch/pytorch/assets/475357/849d4aa7-79f6-47fa-a471-d452d7c1bdf6)

Pull Request resolved: 
8000
pytorch#111071
Approved by: https://github.com/atalman
@huydhn huydhn mentioned this pull request Oct 11, 2023
Closed
huydhn added a commit that referenced this pull request Oct 11, 2023
@huydhn
Fix Android publish step with lite interpreter (#111071) (#111083)
0bc598a 
This file needs to be added to the list like others.  The publish command `BUILD_LITE_INTERPRETER=1 android/gradlew -p android publish` finishes successfully with this and files are available on Nexus:

![Screenshot 2023-10-11 at 11 56 53](https://github.com/pytorch/pytorch/assets/475357/849d4aa7-79f6-47fa-a471-d452d7c1bdf6)

Pull Request resolved: #111071
Approved by: https://github.com/atalman
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atalman atalman atalman approved these changes

Assignees
No one assigned
Labels
Merged test-config/docs_test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@huydhn @pytorchmergebot @atalman
0