10000 [functorch] make torch.compile support opt-in by kshitij12345 · Pull Request #108134 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

[functorch] make torch.compile support opt-in #108134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 1, 2023
Merged

[functorch] make torch.compile support opt-in #108134

merged 1 commit into from
Sep 1, 2023

Conversation

kshitij12345
Copy link
Collaborator
@kshitij12345 kshitij12345 commented Aug 29, 2023 •
edited
Loading

This is an experimental feature and we want to make it opt-in for this release.

Setting this to False will still run the relevant tests.

Note: This PR is for release/2.1

pytorch/test/dynamo/test_higher_order_ops.py

Lines 1611 to 1617 in 6d20b39

class FuncTorchHigherOrderOpTests(torch._dynamo.test_case.TestCase):
def run(self, result=None):
# capture_func_transform will be set to False (for 2.1) till we
# support all transforms, so manually patch it to `True`` for
# testing on release branch.
with config.patch(capture_func_transforms=True):
super().run(result)

cc @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @chenyang78 @aakhundov

@pytorch-bot
Copy link
pytorch-bot bot commented Aug 29, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/108134

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d8326f8 with merge base 138e289 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@kshitij12345 kshitij12345 marked this pull request as ready for review August 29, 2023 12:21
@kshitij12345 kshitij12345 requested a review from zou3519 August 29, 2023 12:21
zou3519
zou3519 approved these changes Aug 29, 2023
View reviewed changes
Copy link
Contributor
@zou3519 zou3519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you will need to add this to the release tracker when it shows up

@kshitij12345 kshitij12345 mentioned this pull request Aug 30, 2023
Closed
@atalman atalman merged commit f139dda into pytorch:release/2.1 Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zou3519 zou3519 zou3519 approved these changes

@atalman atalman atalman approved these changes

Assignees
No one assigned
Labels
ciflow/inductor module: dynamo open source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kshitij12345 @zou3519 @atalman @pytorchbot
0