misc. fixes to constraints warnings and errors #100745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Move constraint violation error after constraint discovery warning, and attach them when we have both. 2. Remove verbose internal traceback for relevant guard in constraint violation error. 3. Remove mention of `assume_static_by_default` in specialization warning. 4. Fix indenting of `specializations` body and make it assert individually instead of returning a conjunction. 5. Remove return annotation on signature used in generated `specializations` and `specify_constraints` functions. 6. Split `&` ranges because we don't support them yet. Differential Revision: [D45619852](https://our.internmc.facebook.com/intern/diff/D45619852/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/100745
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8775fe7: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
tugsbayasgalan
approved these changes
May 5, 2023
1. Move constraint violation error after constraint discovery warning, and attach them when we have both. 2. Remove verbose internal traceback for relevant guard in constraint violation error. 3. Remove mention of `assume_static_by_default` in specialization warning. 4. Fix indenting of `specializations` body and make it assert individually instead of returning a conjunction. 5. Remove return annotation on signature used in generated `specializations` and `specify_constraints` functions. 6. Split `&` ranges because we don't support them yet. Differential Revision: [D45619852](https://our.internmc.facebook.com/intern/diff/D45619852/) cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
1. Move constraint violation error after constraint discovery warning, and attach them when we have both. 2. Remove verbose internal traceback for relevant guard in constraint violation error. 3. Remove mention of `assume_static_by_default` in specialization warning. 4. Fix indenting of `specializations` body and make it assert individually instead of returning a conjunction. 5. Remove return annotation on signature used in generated `specializations` and `specify_constraints` functions. 6. Split `&` ranges because we don't support them yet. Differential Revision: [D45619852](https://our.internmc.facebook.com/intern/diff/D45619852/) cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
avikchaudhuri
added a commit
that referenced
this pull request
May 5, 2023
Pull Request resolved: #100745 1. Move constraint violation error after constraint discovery warning, and attach them when we have both. 2. Remove verbose internal traceback for relevant guard in constraint violation error. 3. Remove mention of `assume_static_by_default` in specialization warning. 4. Fix indenting of `specializations` body and make it assert individually instead of returning a conjunction. 5. Remove return annotation on signature used in generated `specializations` and `specify_constraints` functions. 6. Split `&` ranges because we don't support them yet. ghstack-source-id: 188286662 Differential Revision: [D45619852](https://our.internmc.facebook.com/intern/diff/D45619852/)
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: Command Details for Dev Infra teamRaised by workflow job |
1. Move constraint violation error after constraint discovery warning, and attach them when we have both. 2. Remove verbose internal traceback for relevant guard in constraint violation error. 3. Remove mention of `assume_static_by_default` in specialization warning. 4. Fix indenting of `specializations` body and make it assert individually instead of returning a conjunction. 5. Remove return annotation on signature used in generated `specializations` and `specify_constraints` functions. 6. Split `&` ranges because we don't support them yet. Differential Revision: [D45619852](https://our.internmc.facebook.com/intern/diff/D45619852/) cc soumith voznesenskym penguinwu anijain2305 EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
avikchaudhuri
added a commit
that referenced
this pull request
May 6, 2023
Pull Request resolved: #100745 1. Move constraint violation error after constraint discovery warning, and attach them when we have both. 2. Remove verbose internal traceback for relevant guard in constraint violation error. 3. Remove mention of `assume_static_by_default` in specialization warning. 4. Fix indenting of `specializations` body and make it assert individually instead of returning a conjunction. 5. Remove return annotation on signature used in generated `specializations` and `specify_constraints` functions. 6. Split `&` ranges because we don't support them yet. ghstack-source-id: 188325727 Differential Revision: [D45619852](https://our.internmc.facebook.com/intern/diff/D45619852/)
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
assume_static_by_defaultin specialization warning.specializationsbody and make it assert individually instead of returning a conjunction.specializationsandspecify_constraintsfunctions.&ranges because we don't support them yet.Differential Revision: D45619852
cc @soumith @voznesenskym @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire