8000 `argsort` is missing the `stable` parameter · Issue #70922 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

argsort is missing the stable parameter #70922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Tracked by #58743
pmeier opened this issue Jan 6, 2022 · 2 comments
Closed
Tracked by #58743

argsort is missing the stable parameter #70922

pmeier opened this issue Jan 6, 2022 · 2 comments
Assignees
@HaoZeke
Labels
module: python array api Issues related to the Python Array API module: sorting and selection triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@pmeier
Copy link
Collaborator
pmeier commented Jan 6, 2022 •
edited by pytorch-probot bot
Loading

The array API specification stipulates that torch.argsort should support the same parameters as torch.argsort. Excluding out, stable: bool = True is missing from torch.argsort.

cc @mruberry @rgommers @pmeier @asmeurer @leofang @AnirudhDagar @asi1024 @emcastillo @kmaehashi
@pmeier pmeier added module: sorting and selection module: python array api Issues related to the Python Array API labels Jan 6, 2022
@pmeier pmeier mentioned this issue Jan 6, 2022
8000 Open
29 tasks
@ngimel ngimel added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 6, 2022
@rgommers
Copy link
Collaborator
rgommers commented Jan 6, 2022

sort does have this keyword and algorithm, and argsort just returns the second return value of sort - so this should be low-hanging fruit.

@HaoZeke HaoZeke self-assigned this Mar 10, 2022
@HaoZeke HaoZeke mentioned this issue Apr 3, 2022
Closed
pytorchmergebot pushed a commit that referenced this issue Jun 9, 2022
@HaoZeke @pytorchmergebot
MAINT: Harmonize argsort params with array_api (#75162)
0440743 
Closes [#70922](#70922).
- Does what it says on the tin.
-  No non-standard implementation details.
Pull Request resolved: #75162
Approved by: https://github.com/rgommers, https://github.com/nikitaved, https://github.com/mruberry
facebook-github-bot pushed a commit that referenced this issue Jun 10, 2022
@HaoZeke @facebook-github-bot
MAINT: Harmonize argsort params with array_api (#75162) (#75162)
4581057 
Summary:
Closes [#70922](#70922).
- Does what it says on the tin.
-  No non-standard implementation details.

Pull Request resolv
8000
ed: #75162
Approved by: https://github.com/rgommers, https://github.com/nikitaved, https://github.com/mruberry

Test Plan: contbuild & OSS CI, see https://hud.pytorch.org/commit/pytorch/pytorch/04407431ffe529d3811802674a1a771c5c6562e4

Reviewed By: osalpekar

Differential Revision: D37058996

Pulled By: osalpekar

fbshipit-source-id: d8dedd8d1892f45448c356558774a8c1b20d96d2
@rgommers
Copy link
Collaborator
rgommers commented Mar 7, 2023

This was fixed in gh-75162, so closing.

@rgommers rgommers closed this as completed Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@HaoZeke HaoZeke

Labels
module: python array api Issues related to the Python Array API module: sorting and selection triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

MAINT: Harmonize argsort params with array_api HaoZeke/pytorch
4 participants
@rgommers @HaoZeke @pmeier @ngimel
0