E59B Reductions tracking issue · Issue #61417 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Reductions tracking issue #61417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
14 of 51 tasks
heitorschueroff opened this issue Jul 8, 2021 · 0 comments
Open
14 of 51 tasks

Reductions tracking issue #61417

heitorschueroff opened this issue Jul 8, 2021 · 0 comments
Labels
module: numpy Related to numpy support, and also numpy compatibility of our operators module: reductions tracker A tracking issue triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@heitorschueroff
Copy link
Contributor
heitorschueroff commented Jul 8, 2021 •
edited
Loading

This issue is for tracking and organizing tasks related to reduction operators. For 1.10 we are focusing on aligning API with the Python Array API Standard and test improvements.

Note that some of the tasks below need further discussion before we decide to commit to them.

API

Reduction operators should implement the Python Array API Standard which includes supporting all data types (unless noted in the documentation otherwise) and performing type promotion. They should be compatible with NumPy where possible (giving higher priority to the Python Array API Standard). Where applicable, they should support reducing over multiple dimensions.

Python Array API Standard

NumPy compatibility

Scalar and empty tensors

Variants

Type Promotion

Testing

Reduction operators have additional structure than other operators such as dim and keepdim parameters which can be exploited to automate testing of many features. To do so, we can create a ReductionInfo subclass of OpInfo and update test_reductions.py to follow the OpInfo pattern. Some example of tests that can be automated are ensuring reduction operators support reducing over multiple dimensions, reducing over nonzero dimensions of empty tensors, and even testing for correctness by providing a reference implementation such as a NumPy equivalent operator.

Bugs

Performance

Feature Requests

Allow specifying a range for dimensions to reduce over

Miscellaneous

cc @mruberry @rgommers @heitorschueroff @gchanan
@heitorschueroff heitorschueroff self-assigned this Jul 8, 2021
@heitorschueroff heitorschueroff added the module: numpy Related to numpy support, and also numpy compatibility of our operators label Jul 8, 2021
@heitorschueroff heitorschueroff changed the title Reductions Tracking Issue Reductions tracking issue Jul 8, 2021
@iramazanli iramazanli added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jul 8, 2021
@heitorschueroff heitorschueroff mentioned this issue Jul 9, 2021
Open
@mruberry mruberry mentioned this issue Jul 19, 2021
Closed
@heitorschueroff heitorschueroff removed their assignment Sep 16, 2021
@anilkeshwani anilkeshwani mentioned this issue Nov 1, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: numpy Related to numpy support, and also numpy compatibility of our operators module: reductions tracker A tracking issue triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@heitorschueroff @iramazanli
0