8000 Change make_reduction to reflect input resizing. · Issue #56764 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Change make_reduction to reflect input resizing. #56764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Tracked by #61417
v0dro opened this issue Apr 23, 2021 · 0 comments
Open
Tracked by #61417

Change make_reduction to reflect input resizing. #56764

v0dro opened this issue Apr 23, 2021 · 0 comments
Labels
better-engineering Relatively self-contained tasks for better engineering contributors module: reductions triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@v0dro
Copy link
Contributor
v0dro commented Apr 23, 2021 •
edited by pytorch-probot bot
Loading

🚀 Feature

The make_reduction function in ReduceOpsUtils.h resizes the input tensor, but this is not obvious from the function name. Changing the name would be a useful change in terms of usability.

Motivation

In this comment (https://github.com/pytorch/pytorch/pull/52565/files#r616911706) of this PR (#52565) , it can be seen that even though we rely on make_reduction to change the sizes of the tensors, the same is not reflected in the function name and leaves one wondering about the change that the function makes on the input tensors.

Pitch

A different, better name for make_reduction, for example reduce_and_resize or get_reduction_and_resize would be nice.

cc @heitorschueroff
@v0dro v0dro mentioned this issue Apr 23, 2021
Closed
@ezyang ezyang added better-engineering Relatively self-contained tasks for better engineering contributors module: reductions triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Apr 23, 2021
@heitorschueroff heitorschueroff mentioned this issue Jul 8, 2021
Open
51 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
better-engineering Relatively self-contained tasks for better engineering contributors module: reductions triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ezyang @v0dro
0