8000 DISABLED test_nonstrict_trace_no_action_at_a_distance (__main__.DecoratorTests) · Issue #148034 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

DISABLED test_nonstrict_trace_no_action_at_a_distance (__main__.DecoratorTests) #148034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pytorch-bot bot opened this issue Feb 27, 2025 · 4 comments
Closed

DISABLED test_nonstrict_trace_no_action_at_a_distance (__main__.DecoratorTests) #148034

pytorch-bot bot opened this issue Feb 27, 2025 · 4 comments
Assignees
@StrongerXi
Labels
module: dynamo module: flaky-tests Problem is a flaky test in CI oncall: pt2 skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Comments

@pytorch-bot
Copy link
pytorch-bot bot commented Feb 27, 2025 •
edited
Loading

Platforms: linux, mac, macos

This test was disabled because it is failing in CI. See recent examples and the most recent trunk workflow logs.

Over the past 3 hours, it has been determined flaky in 5 workflow(s) with 5 failures and 5 successes.

Debugging instructions (after clicking on the recent samples link):
DO NOT ASSUME THINGS ARE OKAY IF THE CI IS GREEN. We now shield flaky tests from developers so CI will thus be green but it will be harder to parse the logs.
To find relevant log snippets:

  1. Click on the workflow logs linked above
  2. Click on the Test step of the job so that it is expanded. Otherwise, the grepping will not work.
  3. Grep for test_nonstrict_trace_no_action_at_a_distance
  4. There should be several instances run (as flaky tests are rerun in CI) from which you can study the logs.
Sample error message 
Traceback (most recent call last):
  File "/Users/ec2-user/runner/_work/pytorch/pytorch/test/dynamo/test_decorators.py", line 558, in test_nonstrict_trace_no_action_at_a_distance
    self.assertEqual(cnts.frame_count, 2)
  File "/Users/ec2-user/runner/_work/_temp/conda_environment_13552406917/lib/python3.9/site-packages/torch/testing/_internal/common_utils.py", line 4096, in assertEqual
    raise error_metas.pop()[0].to_error(  # type: ignore[index]
AssertionError: Scalars are not equal!

Expected 2 but got 1.
Absolute difference: 1
Relative difference: 0.5

To execute this test, run the following from the base repo dir:
    python test/dynamo/test_decorators.py DecoratorTests.test_nonstrict_trace_no_action_at_a_distance

This message can be suppressed by setting PYTORCH_PRINT_REPRO_ON_FAILURE=0

Test file path: dynamo/test_decorators.py

cc @clee2000 @voznesenskym @penguinwu @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @chenyang78 @kadeng @chauhang @amjames
@pytorch-bot pytorch-bot bot added module: dynamo module: flaky-tests Problem is a flaky test in CI skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels Feb 27, 2025
@pytorch-bot PyTorch Bot
8000 Copy link
Author
pytorch-bot bot commented Feb 27, 2025
Hello there! From the DISABLED prefix in this issue title, it looks like you are attempting to disable a test in PyTorch CI. The information I have parsed is below:
  • Test name: test_nonstrict_trace_no_action_at_a_distance (__main__.DecoratorTests)
  • Platforms for which to skip the test: linux, mac, macos
  • Disabled by pytorch-bot[bot]

Within ~15 minutes, test_nonstrict_trace_no_action_at_a_distance (__main__.DecoratorTests) will be disabled in PyTorch CI for these platforms: linux, mac, macos. Please verify that your test name looks correct, e.g., test_cuda_assert_async (__main__.TestCuda).

To modify the platforms list, please include a line in the issue body, like below. The default action will disable the test for all platforms if no platforms list is specified.

Platforms: case-insensitive, list, of, platforms

We currently support the following platforms: asan, dynamo, inductor, linux, mac, macos, rocm, slow, win, windows.

How to re-enable a test

To re-enable the test globally, close the issue. To re-enable a test for only a subset of platforms, remove the platforms from the list in the issue body. This may take some time to propagate. To re-enable a test only for a PR, put Fixes #148034 in the PR body and rerun the test jobs. Note that if a test is flaky, it maybe be difficult to tell if the test is still flaky on the PR.

@pytorch-bot PyTorch Bot
Copy link
Author
pytorch-bot bot commented Feb 27, 2025

Another case of trunk flakiness has been found here. The list of platforms [linux, mac, macos] appears to contain all the recently affected platforms [linux, mac, macos]. Either the change didn't propogate fast enough or disable bot might be broken.

@pytorch-bot PyTorch Bot
Copy link
Author
pytorch-bot bot commented Feb 27, 2025

Another case of trunk flakiness has been found here. The list of platforms [linux, mac, macos] appears to contain all the recently affected platforms [linux, mac, macos]. Either the change didn't propogate fast enough or disable bot might be broken.

@StrongerXi StrongerXi mentioned this issue Mar 4, 2025
Closed
pytorchmergebot pushed a commit that referenced this issue Mar 5, 2025
8000 @StrongerXi @pytorchmergebot
[dynamo] Account for function id reuse in relevant Dynamo decorators (#…
a10f577 
…148385)

This fixes a recent series of flaky failure from `nonstrict_trace` unit
tests: #148166, #148056, #148055, #148054, #148034, #148033, #148032, #148031.

For now we don't need to worry about the other decorators because they
are either meant for builtin/numpy functions (which should never
deallocate in practice), or used for polyfills which keeps the function
object in `get_torch_obj_rule_map()`.

Fixes #147777.

Pull Request resolved: #148385
Approved by: https://github.com/zou3519
pytorchmergebot pushed a commit that referenced this issue Mar 5, 2025
@StrongerXi @pytorchmergebot
[dynamo] Account for function id reuse in relevant Dynamo decorators
cb317a4 
This fixes a recent series of flaky failure from `nonstrict_trace` unit
tests: #148166, #148056, #148055, #148054, #148034, #148033, #148032, #148031.

For now we don't need to worry about the other decorators because they
are either meant for builtin/numpy functions (which should never
deallocate in practice), or used for polyfills which keeps the function
object in `get_torch_obj_rule_map()`.

Fixes #147777.

ghstack-source-id: d9bea5f
Pull Request resolved: #148385
@StrongerXi
Copy link
Contributor

Closed by #148385

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StrongerXi StrongerXi

Labels
module: dynamo module: flaky-tests Problem is a flaky test in CI oncall: pt2 skipped Denotes a (flaky) test currently skipped in CI. triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@StrongerXi
0