8000 The `sympy` dependency spec for pytorch on PyPi wheel is still unchanged. · Issue #145225 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

The sympy dependency spec for pytorch on PyPi wheel is still unchanged. #145225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
stevenleeS0ht opened this issue Jan 20, 2025 · 4 comments
Closed

The sympy dependency spec for pytorch on PyPi wheel is still unchanged. #145225

stevenleeS0ht opened this issue Jan 20, 2025 · 4 comments
Assignees
@malfet
Labels
module: third_party oncall: releng In support of CI and Release Engineering triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Milestone
2.7.0

Comments

@stevenleeS0ht
Copy link

When run pip install -U torch, it will still require sympy==1.13.1 and will uninstall the latest sympy which is version 1.13.3 in the virtual environment.

The reason is due to the dependency spec unchanged in setup.py.
@stevenleeS0ht stevenleeS0ht mentioned this issue Jan 20, 2025
Closed
@malfet
Copy link
Contributor
malfet commented Jan 21, 2025 •
edited
Loading

Lets discuss it during the triage review meeting, as this issue appears a few times, but probably should be handled by PT2 team, who heavily depends on specific sympy behavior. IMO it would be great to keep it pinned only to the minor version, but may be folks can share an example when sympy update caused regressions

@atalman
Copy link
Contributor
atalman commented Jan 27, 2025

I confirm this is what we currently have in METADATA section of the wheel:

Requires-Dist: sympy (==1.13.1) ; python_version >= "3.9"

@drisspg drisspg added triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module and removed triage review labels Jan 27, 2025
@malfet
Copy link
Contributor
malfet commented Jan 27, 2025

It should be relaxed to >= 1.13.1

@drisspg drisspg added the oncall: releng In support of CI and Release Engineering label Jan 27, 2025
@huydhn huydhn added this to the 2.7.0 milestone Feb 4, 2025
@clee2000
Copy link
Contributor

Does #147197 fix this?

@ZainRizvi ZainRizvi moved this to Prioritized in PyTorch OSS Dev Infra Mar 4, 2025
malfet added a commit that referenced this issue Mar 5, 2025
@malfet
[BE] Relax sympy dependency to 1.13.3 or newer
5c436da 
Fixes #145225
@malfet malfet mentioned this issue Mar 5, 2025
Closed
@github-project-automation github-project-automation bot moved this from Prioritized to Done in PyTorch OSS Dev Infra Mar 5, 2025
@atalman atalman mentioned this issue Apr 3, 2025
Closed
65 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@malfet malfet

Labels
module: third_party oncall: releng In support of CI and Release Engineering triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
PyTorch OSS Dev Infra
Archived in project
Milestone
2.7.0
Development

Successfully merging a pull request may close this issue.

[BE] Relax sympy dependency to 1.13.3 or newer pytorch/pytorch
6 participants
@huydhn @malfet @atalman @drisspg @stevenleeS0ht @clee2000
0