8000 Document ProcessGroupOptions · Issue #130958 · pytorch/pytorch · GitHub
[go: up one dir, main page]
Skip to content

Document ProcessGroupOptions #130958

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
ezyang opened this issue Jul 17, 2024 · 0 comments
Open

Document ProcessGroupOptions #130958

ezyang opened this issue Jul 17, 2024 · 0 comments
Labels
module: docs Related to our documentation, both in docs/ and docblocks oncall: distributed Add this issue/PR to distributed oncall triage queue triage review

Comments

@ezyang
Copy link
Contributor
ezyang commented Jul 17, 2024 •
edited by pytorch-bot bot
Loading

🐛 Describe the bug

It is referenced in the docs but not defined anywhere.

See also #130957

Versions

main

cc @XilunWu @H-Huang @awgu @kwen2501 @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k @c-p-i-o @svekars @brycebortree
@ezyang ezyang added the oncall: distributed Add this issue/PR to distributed oncall triage queue label Jul 17, 2024
@yf225 yf225 added module: docs Related to our documentation, both in docs/ and docblocks triage review labels Jul 20, 2024
@fduwjj fduwjj mentioned this issue Aug 7, 2024
Closed
fduwjj added a commit that referenced this issue Aug 27, 2024
@fduwjj
Update base for Update on "[c10d] Expose backend Options to reflect t…
a0a22d7 
…he correct code structure"


Although it looks like documents for Options mentioned in #130958 have been all addressed. What I noticed is that we still assume PGNCCL is using option from ProcessGroup but we actually should make it use Option from backend class. So this PR is to make the type or name to be aligned with what we are doing in cpp side. I don't change the signature for the public API, so they still use args named "pg_options"


cc XilunWu H-Huang awgu kwen2501 wanchaol fegin wz337 wconstab d4l3k c-p-i-o

[ghstack-poisoned]
fduwjj added a commit that referenced this issue Aug 27, 2024
@fduwjj
Update on "[c10d] Expose backend Options to reflect the correct code …
fe2d504 
…structure"


Although it looks like documents for Options mentioned in #130958 have been all addressed. What I noticed is that we still assume PGNCCL is using option from ProcessGroup but we actually should make it use Option from backend class. So this PR is to make the type or name to be aligned with what we are doing in cpp side. I don't change the signature for the public API, so they still use args named "pg_options"


cc XilunWu H-Huang awgu kwen2501 wanchaol fegin wz337 wconstab d4l3k c-p-i-o

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
module: docs Related to our documentation, both in docs/ and docblocks oncall: distributed Add this issue/PR to distributed oncall triage queue triage review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ezyang @yf225
0