Check for error messages on torch.compile with pybind'ed functions #126799

zou3519 · 2024-05-21T18:21:17Z

These should recommend usage of the custom ops APIs. Suggested by @jansel

cc @ezyang @msaroufim @bdhirsh @anijain2305 @chauhang

…C++ extension" Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nice error message for that. Fixes #126799 Test Plan: - new test [ghstack-poisoned]

Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nice error message for that. Fixes #126799 Test Plan: - new test [ghstack-poisoned]

Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nice error message for that. Fixes #126799 Test Plan: - new test ghstack-source-id: 7e20854 Pull Request resolved: #127301

…C++ extension" Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nice error message for that. Fixes #126799 Test Plan: - new test [ghstack-poisoned]

Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nice error message for that. Fixes #126799 Test Plan: - new test [ghstack-poisoned]

…C++ extension" Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nice error message for that. Fixes #126799 Test Plan: - new test [ghstack-poisoned]

Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nice error message for that. Fixes #126799 Test Plan: - new test [ghstack-poisoned]

…namo x Python C++ extension" Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nicer graph break message and also changes it to unconditionally warn on this graph break (because graph break messages are usually not visible). Fixes #126799 Test Plan: - new test [ghstack-poisoned]

…+ extension" Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nicer graph break message and also changes it to unconditionally warn on this graph break (because graph break messages are usually not visible). Fixes #126799 Test Plan: - new test [ghstack-poisoned]

…namo x Python C++ extension" Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nicer graph break message and also changes it to unconditionally warn on this graph break (because graph break messages are usually not visible). Fixes #126799 Test Plan: - new test [ghstack-poisoned]

…+ extension" Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nicer graph break message and also changes it to unconditionally warn on this graph break (because graph break messages are usually not visible). Fixes #126799 Test Plan: - new test [ghstack-poisoned]

…namo x Python C++ extension" Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nicer graph break message and also changes it to unconditionally warn on this graph break (because graph break messages are usually not visible). Fixes #126799 Test Plan: - new test [ghstack-poisoned]

…+ extension" Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nicer graph break message and also changes it to unconditionally warn on this graph break (because graph break messages are usually not visible). Fixes #126799 Test Plan: - new test [ghstack-poisoned]

…namo x Python C++ extension" Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nicer graph break message and also changes it to unconditionally warn on this graph break (because graph break messages are usually not visible). Fixes #126799 Test Plan: - new test cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]

…+ extension" Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nicer graph break message and also changes it to unconditionally warn on this graph break (because graph break messages are usually not visible). Fixes #126799 Test Plan: - new test cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]

…namo x Python C++ extension" Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nicer graph break message and also changes it to unconditionally warn on this graph break (because graph break messages are usually not visible). Fixes #126799 Test Plan: - new test cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]

…+ extension" Dynamo graph breaks on Python C/C++ extensions (e.g. pybinded functions). The usual way to handle this is to turn those extensions into custom ops. This PR adds a nicer graph break message and also changes it to unconditionally warn on this graph break (because graph break messages are usually not visible). Fixes #126799 Test Plan: - new test cc voznesenskym penguinwu EikanWang jgong5 Guobing-Chen XiaobingSuper zhuhaozhe blzheng wenzhe-nrv jiayisunx chenyang78 kadeng chauhang [ghstack-poisoned]

zou3519 added this to the 2.4.0 milestone May 21, 2024

zou3519 added the module: pt2-dispatcher PT2 dispatcher-related issues (e.g., aotdispatch, functionalization, faketensor, custom-op, label May 21, 2024

zou3519 self-assigned this May 21, 2024

pytorch-bot bot added the oncall: pt2 label May 21, 2024

mlazos added enhancement Not as big of a feature, but technically not a bug. Should be easy to fix triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module labels May 23, 2024

zou3519 mentioned this issue May 28, 2024

Better graph break msg (and warning) on Dynamo x Python C++ extension #127301

Closed

pytorchmergebot closed this as completed in ffe506e May 30, 2024

atalman mentioned this issue Jul 5, 2024

Release 2.4.0 validations checklist and cherry-picks #130151

Closed

29 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Check for error messages on torch.compile with pybind'ed functions #126799

Check for error messages on torch.compile with pybind'ed functions #126799

Check for error messages on torch.compile with pybind'ed functions #126799

Check for error messages on torch.compile with pybind'ed functions #126799

Comments

Uh oh!