inductor_config_logging: Don't drop keys

c00w · c00w · commit bf6f0c0273e7 · 2025-01-21T17:02:33.000-08:00
This bit me while I was trying to debug some trace issues. In general this config is already quite large when dumping, so adding more fields doesn't make it significantly worse. Also a number of the items we are type checking for (except the test configs), don't even show up. Primarily this will help us when debugging rocm, halide, and trace configs. ghstack-source-id: bf8a1a7 Pull Request resolved: #144700
diff --git a/test/dynamo/test_utils.py b/test/dynamo/test_utils.py
@@ -387,6 +387,7 @@ def test_inductor_config_jsonify(self):
 
         inductor_config_json = utils._scrubbed_inductor_config_for_logging()
         self.assertTrue(isinstance(inductor_config_json, str))
+        self.assertIn('trace"', inductor_config_json)
 
     @mock.patch("torch._dynamo.utils.torch._inductor.config")
     def test_inductor_config_parsing_non_conforming_items(self, mocked_inductor_config):
diff --git a/torch/_dynamo/utils.py b/torch/_dynamo/utils.py
@@ -1331,16 +1331,15 @@ def default(self, o):
             except Exception:
                 return "Value is not JSON serializable"
 
-    configs_to_scrub_re = r"((^TYPE_CHECKING$)|(.*_progress$)|(.*TESTING.*)|(.*(rocm|halide).*)|(^trace\..*)|(^_))"
-    keys_to_scrub = set()
+    keys_to_scrub: Set[Any] = set()
     inductor_conf_str = None
     inductor_config_copy = (
         torch._inductor.config.get_config_copy() if torch._inductor.config else None
     )
     if inductor_config_copy is not None:
         try:
             for key, val in inductor_config_copy.items():
-                if not isinstance(key, str) or re.search(configs_to_scrub_re, key):
+                if not isinstance(key, str):
                     keys_to_scrub.add(key)
                 # Convert set() to list for json.dumps()
                 if isinstance(val, set):
