8000 [Fix CI] Convert tiles to sizes for all torch.* functions by yf225 · Pull Request #563 · pytorch/helion · GitHub
[go: up one dir, main page]
Skip to content

[Fix CI] Convert tiles to sizes for all torch.* functions #563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 5, 2025
Merged

[Fix CI] Convert tiles to sizes for all torch.* functions #563

merged 1 commit into from
Sep 5, 2025

Conversation

@yf225
Copy link
Contributor
@yf225 yf225 commented Sep 5, 2025

After PyTorch upstream PR pytorch/pytorch#160256, Helion CI is failing with errors like:

FAILED test/test_views.py::TestViews::test_softmax_view_reshape - helion.exc.IncorrectTileUsage: Tiles can only be used in tensor indexing (`x[tile]`) or in `hl.*` ops (e.g. `hl.zeros(tile)`), used in <method 'view' of 'torch._C.TensorBase' objects>
While processing:
  File "/__w/helion/helion/test/test_views.py", line 45, in softmax
    amax = torch.amax(values, dim=1).view(tile_n, 1)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

This PR fixes it.

@yf225 yf225 requested review from jansel and oulgen September 5, 2025 00:17
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 5, 2025
@yf225 yf225 marked this pull request as draft September 5, 2025 00:18
@yf225 yf225 changed the title [Fix CI] Convert tiles to sizes for all torch.* functions [WIP][Fix CI] Convert tiles to sizes for all torch.* functions Sep 5, 2025
@yf225 yf225 force-pushed the fix_CI_tile_usage_error branch from 01491b7 to 7bd030b Compare September 5, 2025 00:22
@yf225 yf225 marked this pull request as ready for review September 5, 2025 00:22
@yf225 yf225 changed the title [WIP][Fix CI] Convert tiles to sizes for all torch.* functions [Fix CI] Convert tiles to sizes for all torch.* functions Sep 5, 2025
@oulgen oulgen merged commit a61bd17 into main Sep 5, 2025
13 checks passed
@oulgen oulgen mentioned this pull request Sep 5, 2025
Closed
lolpack pushed a commit to lolpack/helion that referenced this pull request Oct 13, 2025
@yf225 @lolpack
[Fix CI] Convert tiles to sizes for all torch.* functions (pytorch#563)
498bcda
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oulgen oulgen oulgen approved these changes

@jansel jansel Awaiting requested review from jansel

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yf225 @oulgen
0