8000 Removing uneeded buck deps in cmake build flow by BujSet · Pull Request #11315 · pytorch/executorch · GitHub
[go: up one dir, main page]
Skip to content

Removing uneeded buck deps in cmake build flow #11315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2025
Merged

Removing uneeded buck deps in cmake build flow #11315

merged 1 commit into from
Jun 3, 2025

Conversation

BujSet
Copy link
Contributor
@BujSet BujSet commented Jun 3, 2025 •
edited
Loading

Summary

The buck and cmake build flows should be independent, where the cmake build flow should not rely on buck targets to be built or used.

Test plan

Tested on examples and tutorials, and no functional difference was seen between runs before and after change.

@pytorch-bot PyTorch Bot
Copy link
pytorch-bot bot commented Jun 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11315

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure

As of commit 992ac41 with merge base 5ef38d3 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jun 3, 2025
@BujSet
Copy link
Contributor Author
BujSet commented Jun 3, 2025

@pytorchbot label "release notes: none"

@pytorch-bot pytorch-bot bot added the release notes: none Do not include this in the release notes label Jun 3, 2025
@BujSet BujSet self-assigned this Jun 3, 2025
@BujSet BujSet marked this pull request as ready for review June 3, 2025 22:38
@BujSet BujSet merged commit 450d1f9 into pytorch:main Jun 3, 2025
376 of 382 checks passed
@BujSet BujSet deleted the remove_buck_dep_in_cmake branch June 19, 2025 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucylq lucylq lucylq approved these changes

@larryliu0820 larryliu0820 Awaiting requested review from larryliu0820 larryliu0820 is a code owner

@JacobSzwejbka JacobSzwejbka Awaiting requested review from JacobSzwejbka JacobSzwejbka is a code owner

Assignees

@BujSet BujSet

Labels
ciflow/binaries ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: none Do not include this in the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BujSet @lucylq @facebook-github-bot
0