[ET-VK][Ops] aten.tan.default in unary_ops #11153
Conversation
Pull Request resolved: #11046 Goal is to create the tan operator and its test case ghstack-source-id: 286384697 @exported-using-ghexport Differential Revision: [D75100188](https://our.internmc.facebook.com/intern/diff/D75100188/)
Pull Request resolved: #11047 Adds tan to unary_ops, as it doesn't already exist ghstack-source-id: 286384698 Differential Revision: [D75112807](https://our.internmc.facebook.com/intern/diff/D75112807/)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/11153
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 2 New FailuresAs of commit b2b470f with merge base af0a246 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
There was a problem hiding this comment.
I don't think we can land this PR since it is so old. If it's landed now, there will two definitions of the tan op, one in Tan.cpp and one in UnaryOp.cpp since this PR doesn't remove the Tan.cpp file. Note that Tan.cpp was relanded as part of D75920603 because the diff train couldn't link the landed PR to the original diff that was landed internally.
|
Closing this PR based off comments from @SS-JIA |
This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #11047 by @ahmtox
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/ahmtox/3/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/ahmtox/3/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/gh/ahmtox/2/orig
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/ahmtox/3/orig
@diff-train-skip-merge