This repository was archived by the owner on Jun 9, 2020. It is now read-only.
Release v2.3 #2
Merged
Release v2.3 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
March 12, 2017 21:27
…thon2.7-mono4.8.0-pythonnet2.3
…thon3.5-mono4.8.0-pythonnet2.3
|
We could remove the specified version and just make it generic so that we don't have to keep updating this for every version. If we going for version specific, it should be the full version |
|
The only reason it's specifically versioned is because of the combination of everything. Otherwise we could leave it more generic. |
|
LGTM. Sorry I've been a ghost for the past week. I've been really sick and am now coming out of it. Thanks for taking the initiative on this. Let me know if I can help any other way. |
|
It makes sense to freeze Python version, even mono to a certain degree, but I think we should float the |
|
@vmuriart I'm not sure how you would float the |
|
|
|
@vmuriart We shouldn't do that because it creates a moving target on Docker. If you overwrite the tag with a new version, only environments specifically looking to pull the latest will get the latest, so some environments will have an older version while others have a new one. It's against Docker best-practices. |
8000
|
Docker assumes your tagged image will not change. |
|
makes sense then. ok to merge/squash once the full version name is used then ( |
|
I agree with full version name. |
added 7 commits
March 13, 2017 15:31
…on2.7-mono4.8.0-pythonnet2.3.0
…on3.5-mono4.8.0-pythonnet2.3.0
|
@cowboygneox @vmuriart updated, why is there a dot at the end of this command? pythonnet-docker/build_and_deploy.sh Line 5 in d16fe95 |
|
@denfromufa the |
|
Should we setup Travis CI to build and push these images?
…On Mon, Mar 13, 2017, 5:13 PM Victor Uriarte ***@***.***> wrote:
Merged #2 <#2>.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHgZ5XDNyIe1N0dWQ1QnkHh8lSKFDsLJks5rlb-EgaJpZM4MayLD>
.
|
|
IIRC, Travis doesn't provide the access necessary to build these images. Maybe they do now... |
|
@cowboygneox @vmuriart do you know why the |
|
@vmuriart @cowboygneox only mono-complete amd64 4.8.0.520-0xamarin3 was found on my docker setup: |
|
@denfromufa Even though there is Docker support on Windows, my impression is that it's better to avoid building images on Windows. I've had success with running pre-built images, standard or custom, but I've struggled to get Windows to reproduce the *nix environment necessary to build most images. tl;dr: I wouldn't use Windows to build Docker images. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pythonnet/pythonnet#355
@vmuriart @cowboygneox please review