8000 Add mp_length slot for .NET classes implementing ICollection/ICollection<T> by slide · Pull Request #994 · pythonnet/pythonnet · GitHub
[go: up one dir, main page]
Skip to content

Add mp_length slot for .NET classes implementing ICollection/ICollection<T> #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 16, 2019
Merged

Add mp_length slot for .NET classes implementing ICollection/ICollection<T> #994

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
1c415d0
Add mp_length slot implementation for .NET types
slide Nov 20, 2019
b5261a1
Fix accidentally changed files
slide Nov 21, 2019
90681d5
Fix module docstring and imports
slide Nov 21, 2019
01c56f2
Merge branch 'master' into mp_length
slide Nov 21, 2019
0f07453
Fix non-xplat build
slide Nov 21, 2019
3173023
Fix test project compilation on non-xplat
slide Nov 21, 2019
ea76389
Remove GetCountGetter
slide Nov 21, 2019
8f49346
Update based on feedback
slide Nov 25, 2019
5206efb
Merge branch 'master' into mp_length
filmor Dec 2, 2019
f4fb3cb
Merge branch 'master' into mp_length
filmor Dec 2, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update based on feedback
  • Loading branch information
@slide
slide committed Nov 25, 2019
commit 8f49346e2d80b72e23c6e233cebbd40e60906eda
11 changes: 2 additions & 9 deletions src/runtime/slots/mp_length.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,8 @@ public static int mp_length(IntPtr ob)
return (int)p.GetValue(co.inst, null);
}

// finally look for things that implement the interfaces explicitly
var iface = clrType.GetInterface(nameof(ICollection));
if(iface != null)
{
p = iface.GetProperty(nameof(ICollection.Count));
return (int)p.GetValue(co.inst, null);
}

iface = clrType.GetInterfaces().FirstOrDefault(x => x.IsGenericType && x.GetGenericTypeDefinition() == typeof(ICollection<>));
// finally look for things that implement the interface explicitly
var iface = clrType.GetInterfaces().FirstOrDefault(x => x.IsGenericType && x.GetGenericTypeDefinition() == typeof(ICollection<>));
if (iface != null)
{
p = iface.GetProperty(nameof(ICollection<int>.Count));
Expand Down
0