8000 Remove error-prone text comparison in exception test by filmor · Pull Request #854 · pythonnet/pythonnet · GitHub
[go: up one dir, main page]
Skip to content

Remove error-prone text comparison in exception test #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filmor merged 1 commit into from
Apr 27, 2019
+0 −6
Merged

Remove error-prone text comparison in exception test #854

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions src/tests/test_exceptions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -270,12 +270,6 @@ def test_str_of_exception():
with pytest.raises(FormatException) as cm:
Convert.ToDateTime('this will fail')

e = cm.value
# fix for international installation
msg = text_type(e).encode("utf8")
fnd = text_type('System.Convert.ToDateTime').encode("utf8")
assert msg.find(fnd) > -1, msg


def test_python_compat_of_managed_exceptions():
"""Test managed exceptions compatible with Python's implementation"""
Expand Down
0