Implementing GetDynamicMemberNames() for PyObject #690
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using System.Linq; | ||
| using NUnit.Framework; | ||
| using Python.Runtime; | ||
|
|
||
| namespace Python.EmbeddingTest | ||
| { | ||
| public class TestPyObject | ||
| { | ||
| [OneTimeSetUp] | ||
| public void SetUp() | ||
| { | ||
| PythonEngine.Initialize(); | ||
| } | ||
|
|
||
| [OneTimeTearDown] | ||
| public void Dispose() | ||
| { | ||
| PythonEngine.Shutdown(); | ||
| } | ||
|
|
||
| [Test] | ||
| public void TestGetDynamicMemberNames() | ||
| { | ||
| List<string> expectedMemberNames = new List<string> | ||
| { | ||
| "__class__", | ||
| "__delattr__", | ||
| "__dict__", | ||
| #if PYTHON3 | ||
| "__dir__", | ||
| #endif | ||
| "__doc__", | ||
| #if PYTHON3 | ||
| "__eq__", | ||
| #endif | ||
| "__format__", | ||
| #if PYTHON3 | ||
| "__ge__", | ||
| #endif | ||
| "__getattribute__", | ||
| #if PYTHON3 | ||
| "__gt__", | ||
| #endif | ||
| "__hash__", | ||
| "__init__", | ||
| #if PYTHON36 | ||
| "__init_subclass__", | ||
| #endif | ||
| #if PYTHON3 | ||
| "__le__", | ||
| "__lt__", | ||
| #endif | ||
| "__module__", | ||
| #if PYTHON3 | ||
| "__ne__", | ||
| #endif | ||
| "__new__", | ||
|
There was a problem hiding this comment. The defines here make the whole thing quite brittle, I think, to me it would be perfectly fine to just check that the explicitly added members exist (i.e. |
||
| "__reduce__", | ||
| "__reduce_ex__", | ||
| "__repr__", | ||
| "__setattr__", | ||
| "__sizeof__", | ||
| "__str__", | ||
| "__subclasshook__", | ||
| "__weakref__", | ||
| "add", | ||
| "getNumber", | ||
| "member1", | ||
| "member2" | ||
| }; | ||
|
|
||
| PyDict locals = new PyDict(); | ||
|
|
||
| PythonEngine.Exec(@" | ||
| class MemberNamesTest(object): | ||
| def __init__(self): | ||
| self.member1 = 123 | ||
| self.member2 = 'Test string' | ||
|
|
||
| def getNumber(self): | ||
| return 123 | ||
|
|
||
| def add(self, x, y): | ||
| return x + y | ||
|
|
||
| a = MemberNamesTest() | ||
| ", null, locals.Handle); | ||
|
|
||
| PyObject a = locals.GetItem("a"); | ||
|
|
||
| IEnumerable<string> membernames = a.GetDynamicMemberNames(); | ||
|
|
||
| Assert.AreEqual(expectedMemberNames.Count, membernames.Count(), "Unexpected number of members."); | ||
|
|
||
| IEnumerable<Tuple<string, string>> results = expectedMemberNames.Zip(membernames, (x, y) => new Tuple<string, string>(x, y)); | ||
| foreach (Tuple<string, string> result in results) | ||
| { | ||
| Assert.AreEqual(result.Item1, result.Item2, "Unexpected member name."); | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are not necessary, are they?