8000 Fix the issue of sys.argv being cleared on import clr. by filmor · Pull Request #405 · pythonnet/pythonnet · GitHub
[go: up one dir, main page]
Skip to content

Fix the issue of sys.argv being cleared on import clr. #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 24, 2017
Merged

Fix the issue of sys.argv being cleared on import clr. #405

merged 1 commit into from
Feb 24, 2017

Conversation

filmor
Copy link
Member
@filmor filmor commented Feb 24, 2017

Closes #404.

What does this implement/fix? Explain your changes.

Introduces a setSysArgv flag to all Initialize functions in PythonEngine, defaulting to true and set to false for InitExt such that import clr doesn't call PySys_SetArgvEx.

Does this close any currently open issues?

#404.

Any other comments?

The test should already be in from another PR, from what I understood and since the change introducing this issue has not been released, yet, I don't think it need to go into the changelog.

@vmuriart
Copy link
Contributor
vmuriart commented Feb 24, 2017 •
edited
Loading

@filmor just fixed the test for this on master if you want to check against it.
I ran the test against v2.2.2 and our current master to make sure it passed/xfailed respectively.

test against v2.2.2 - https://travis-ci.org/vmuriart/pythonnet/jobs/204904097

@codecov
Copy link
codecov bot commented Feb 24, 2017

Codecov Report

Merging #405 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #405      +/-   ##
==========================================
+ Coverage   63.49%   63.51%   +0.02%     
==========================================
  Files          60       60              
  Lines        5219     5222       +3     
  Branches      857      858       +1     
==========================================
+ Hits         3314     3317       +3     
  Misses       1685     1685              
  Partials      220      220
Flag Coverage Δ
#Embedded_Tests 32.87% <100%> (+0.02%) ✅
#Python_Tests 60.45% <100%> (-0.18%) ❌
#Setup_Linux 74% <100%> (ø) ✅
#Setup_Windows 70.5% <100%> (ø) ✅
Impacted Files Coverage Δ
src/runtime/pythonengine.cs 66.83% <100%> (+0.51%) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 012b488...9e1a0e4. Read the comment docs.

@vmuriart vmuriart merged commit faf5faf into pythonnet:master Feb 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compatibility issue between argparse and pythonnet packages
2 participants
@filmor @vmuriart
0