8000 [POC] Replace build directives with runtime checks by vmuriart · Pull Request #357 · pythonnet/pythonnet · GitHub
[go: up one dir, main page]
Skip to content

[POC] Replace build directives with runtime checks #357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 4, 2017
Merged

[POC] Replace build directives with runtime checks #357

merged 3 commits into from
Feb 4, 2017

Conversation

vmuriart
Copy link
Contributor
@vmuriart vmuriart commented Feb 4, 2017 •
edited
Loading

What does this implement/fix? Explain your changes.

Proof of concept to separate build directives from runtime to make it Python version agnostic.
Replaces some build directives with runtime if statements.

Ideally continuing down this path would allow us to move the build directives to a few files and allow pythonnet to be mostly python version agnostic.

Does this close any currently open issues?

Maybe lays the ground for #165.

Any other comments?

Based on some of the work from @dmitriyse.

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@codecov-io
Copy link
codecov-io commented Feb 4, 2017 •
edited
Loading

Codecov Report

Merging #357 into master will increase coverage by 0.04%.

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   62.63%   62.67%   +0.04%     
==========================================
  Files          61       61              
  Lines        5245     5251       +6     
  Branches      873      876       +3     
==========================================
+ Hits         3285     3291       +6     
  Misses       1743     1743              
  Partials      217      217
Impacted Files Coverage Δ
src/runtime/converter.cs 76.1% <100%> (ø) ✅
src/runtime/importhook.cs 80.41% <100%> (+0.56%) ✅
src/runtime/exceptions.cs 80.35% <100%> (-0.35%) ❌
src/runtime/runtime.cs 84.67% <93.33%> (+0.23%) ✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update edada03...587f318. Read the comment docs.

@vmuriart vmuriart force-pushed the Remove-Build_Directives branch from 5d1b5a8 to 587f318 Compare February 4, 2017 04:22
@vmuriart vmuriart merged commit c197a64 into pythonnet:master Feb 4, 2017
@vmuriart vmuriart deleted the Remove-Build_Directives branch February 4, 2017 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyroberts tonyroberts tonyroberts approved these changes

@filmor filmor Awaiting requested review from filmor

@den-run-ai den-run-ai Awaiting requested review from den-run-ai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vmuriart @codecov-io @tonyroberts
0