10000 `__delitem__` for `IList<T>` and `IDictionary<K,V>` by lostmsu · Pull Request #2533 · pythonnet/pythonnet · GitHub
[go: up one dir, main page]
Skip to content

__delitem__ for IList<T> and IDictionary<K,V> #2533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 11, 2025
Merged

__delitem__ for IList<T> and IDictionary<K,V> #2533

merged 3 commits into from
Apr 11, 2025

Conversation

lostmsu
Copy link
Member
@lostmsu lostmsu commented Dec 18, 2024 •
edited
Loading

What does this implement/fix? Explain your changes.

Implements __delitem__ for IList<T> and IDictionary<K,V>

Fixes memory leak on using indexer setter.

Fixes crash on attempting to do del o[...] on .NET objects apart from arrays.

Does this close any currently open issues?

Fixes #2530

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Ensure you have signed the .NET Foundation CLA
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

filmor
filmor approved these changes Dec 23, 2024
View reviewed changes
@lostmsu lostmsu merged commit 77bdf6d into pythonnet:master Apr 11, 2025
28 of 30 checks passed
@lostmsu lostmsu deleted the Del branch April 11, 2025 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmor filmor filmor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hard crash when deleting from Dictionary
2 participants
@lostmsu @filmor
0