8000 Fix layout of `NativeTypeSpec` on 32 bit platforms by lostmsu · Pull Request #1765 · pythonnet/pythonnet · GitHub
[go: up one dir, main page]
Skip to content

Fix layout of NativeTypeSpec on 32 bit platforms #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2022
Merged

Fix layout of NativeTypeSpec on 32 bit platforms #1765

merged 2 commits into from
Apr 11, 2022

Conversation

lostmsu
Copy link
Member
@lostmsu lostmsu commented Apr 10, 2022

Does this close any currently open issues?

#1729

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change

@lostmsu lostmsu force-pushed the bugs/32bit-1729 branch 2 times, most recently from f02faa9 to 2dd8a66 Compare April 11, 2022 01:08
filmor
filmor reviewed Apr 11, 2022
View reviewed changes
src/runtime/Native/NativeTypeSpec.cs Outdated
@@ -10,7 +10,7 @@ struct NativeTypeSpec : IDisposable
public readonly StrPtr Name;
public readonly int BasicSize;
public readonly int ItemSize;
public readonly TypeFlags Flags;
public readonly IntPtr Flags;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, Flags is clearly defined as a C int, which should "always" be 32bit, right? (https://docs.python.org/3/c-api/type.html#c.PyType_Spec)

@lostmsu lostmsu force-pushed the bugs/32bit-1729 branch 2 times, most recently from 196f6b6 to cf91f1c Compare April 11, 2022 15:42
@filmor filmor merged commit ab6d2c5 into pythonnet:master Apr 11, 2022
@lostmsu lostmsu deleted the bugs/32bit-1729 branch April 11, 2022 20:05
lostmsu added a commit to losttech/pythonnet that referenced this pull request May 2, 2022
@lostmsu
Revert "Merge pull request pythonnet#1765 from losttech/bugs/32bit-1729"
88ecef6 
This reverts commit ab6d2c5, reversing
changes made to 86c6a7f.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmor filmor filmor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lostmsu @filmor
0