Generate the TypeOffset class automatically. #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than manually tweak the TypeOffset class for each Python release it's easier and more robust to generate it directly from the Python headers.
tonyroberts
added a commit
that referenced
this pull request
Feb 23, 2016
Generate the TypeOffset class automatically.
|
@filmor ah ok, that makes sense. I had done it so it's conditionally included, but I see what you're saying - having to define yet another thing in visual studio could be nicely avoided as you suggest. |
|
@filmor hmm the only downside to that is when building with different python configs (e.g. debug or whatever) the generated file names are different as they include the ABI flags... maybe a conditional include will still be needed for those, but for the most usual cases (i.e. the ones I checked in pre-generated files for) they can all be included and #if/defed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than manually tweak the TypeOffset class for each Python release it's easier and more robust to generate it directly from the Python headers.
This will make the 3.5 upgrade significantly easier.