8000 Make .NET objects that have `__call__` method callable from Python by lostmsu · Pull Request #1589 · pythonnet/pythonnet · GitHub
[go: up one dir, main page]
Skip to content

Make .NET objects that have __call__ method callable from Python #1589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2021
Merged

Make .NET objects that have __call__ method callable from Python #1589

merged 1 commit into from
Oct 14, 2021

Conversation

lostmsu
Copy link
Member
@lostmsu lostmsu commented Oct 6, 2021

What does this implement/fix? Explain your changes.

Implemented by adding tp_call to ClassBase, that uses reflection to find __call__ methods in .NET, and falls back to invoking __call__ method from Python base classes.

Does this close any currently open issues?

Implements #890

Any other comments?

This is an amalgamation of d46878c, 5bb1007, and 960457f from https://github.com/losttech/pythonnet

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Updated the CHANGELOG

@lostmsu lostmsu added this to the 3.0.0 milestone Oct 6, 2021
@lostmsu lostmsu force-pushed the callable branch 4 times, most recently from d0f8cdc to 00cca0f Compare October 7, 2021 00:04
@lostmsu lostmsu requested a review from filmor October 7, 2021 00:09
@lostmsu
make .NET objects that have __call__ method callable from Python
873fe54 
Implemented by adding tp_call to ClassBase, that uses reflection to find __call__ methods in .NET

fixes pythonnet#890

this is an amalgamation of d46878c,  5bb1007, and 960457f from https://github.com/losttech/pythonnet
@filmor filmor merged commit bc3265d into pythonnet:master Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmor filmor filmor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lostmsu @filmor
0