Add a failing test for Unicode conversion #1467
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lostmsu
approved these changes
Jun 8, 2021
lostmsu
requested changes
Jun 9, 2021
|
@filmor requested some minor tweaks |
lostmsu
reviewed
Jun 11, 2021
| char* codePoints = (char*)PyBytes_AsString(p.DangerousGetAddress()); | ||
| var bytesPtr = p.DangerousGetAddress(); | ||
| int bytesLength = (int)Runtime.PyBytes_Size(bytesPtr); | ||
| char* codePoints = (char*)PyBytes_AsString(bytesPtr); |
There was a problem hiding this comment.
NIT: better add overload for PyBytes_AsString that takes BorrowedReference. This would remove unnecessary call to DangerousGetAddress above.
|
@lostmsu Can you reproduce the segfault on Python 3.9? |
|
@filmor it did not fail on rerun. I think we can merge this in, and investigate if it will reappear. |
lostmsu
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
A failing test for #1466
Does this close any currently open issues?
No, just analyzes failure case.
Any other comments?
See #1466
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG