8000 TestPythonEngineProperties.SetPythonPath avoids corrupting the module search path for later tests by tminka · Pull Request #1336 · pythonnet/pythonnet · GitHub
[go: up one dir, main page]
Skip to content

TestPythonEngineProperties.SetPythonPath avoids corrupting the module search path for later tests #1336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 22, 2020
Merged

TestPythonEngineProperties.SetPythonPath avoids corrupting the module search path for later tests #1336

merged 3 commits into from
Dec 22, 2020

Conversation

tminka
Copy link
Contributor
@tminka tminka commented Dec 21, 2020

What does this implement/fix? Explain your changes.

Improves the test suite of Python.NET

Does this close any currently open issues?

Fixes #1335

Any other comments?

This change is not visible to the end user so it doesn't make sense to add it to the CHANGELOG.

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

lostmsu
lostmsu reviewed Dec 22, 2020
View reviewed changes
Copy link
Member
@lostmsu lostmsu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems fine. However, if you wanted this change to add a C# runner for Python tests, I suggest you turn the runner into a separate project file instead.

I'd also suggest to use something like https://stackoverflow.com/questions/866816/dynamically-create-tests-in-nunit to have the test display as individual tests.

@lostmsu lostmsu merged commit 1f40564 into pythonnet:master Dec 22, 2020
@tminka tminka deleted the SetPythonPath branch December 22, 2020 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lostmsu lostmsu lostmsu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TestPythonEngineProperties.SetPythonPath spoils later tests that load modules
2 participants
@tminka @lostmsu
0