10000 Fixed CollectBasicObject test by lostmsu · Pull Request #1313 · pythonnet/pythonnet · GitHub
[go: up one dir, main page]
Skip to content

Fixed CollectBasicObject test #1313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 12, 2020
Merged

Fixed CollectBasicObject test #1313

merged 3 commits into from
Dec 12, 2020

Conversation

lostmsu
Copy link
Member
@lostmsu lostmsu commented Dec 10, 2020 •
edited
Loading

This contains two fixes, that must go along for the tests to pass:

  1. Fixed the CollectBasicObject and CollectOnShutdown tests for Mono by fixing MakeAGarbage function to not keep the garbage on the stack during a conservative roots scan (looks like Mono scans some variables, that are already gone).
  2. Fixed the crash during runtime shutdown by further simplifying Finalizer to only store raw pointers to python objects instead of instances of IPyDisposable and thus replacing Dispose with reliable and simple DecRef.

This removes some functions from Finalizer, which previously were public, but should not have been.

@lostmsu lostmsu force-pushed the bugs/1309 branch 10 times, most recently from 8d89411 to 45c370a Compare December 11, 2020 00:31
@lostmsu lostmsu marked this pull request as ready for review December 11, 2020 02:50
filmor
filmor reviewed Dec 11, 2020
View reviewed changes
Copy link
Member
@filmor filmor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't you use one of the *Reference types instead of IntPtr? It would be good to see at least in the code that we are talking about Python objects here.

src/embed_tests/TestFinalizer.cs
@@ -104,33 +88,45 @@ public void CollectBasicObject()
}

[Test]
[Ignore("Ignore temporarily")]
[Obsolete("GC tests are not guaranteed")]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is NUnit aware of this attribute or does this just generate yet another compile-time warning? Does it help to retry the test using https://docs.nunit.org/articles/nunit/writing-tests/attributes/retry.html?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NUnit is not aware. This actually removes warning from the usage of other [Obsolete] code.

@lostmsu
Copy link
Member Author
lostmsu commented Dec 11, 2020

@filmor not for the finalizer. *Reference types can not be stored.

@filmor filmor merged commit 6bc85ff into pythonnet:master Dec 12, 2020
@lostmsu lostmsu mentioned this pull request Dec 12, 2020
Merged
4 tasks
@lostmsu lostmsu deleted the bugs/1309 branch December 12, 2020 20:02
@lostmsu lostmsu mentioned this pull request Dec 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmor filmor filmor left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lostmsu @filmor
0