Add more domain reload tests #1269
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Domain reload tests should be isolated from each other as much as possible. This framework dynamically creates sub-runners, assemblies, and python modules to do the domain load-unload in an isolated way. As each test requires it's own subprocess, we cannot use nUnit. Leverage pytest to run each subprocess instead.
Just retrieve the object and print it.
This fixes the error in bug pythonnet#1250 by separately serializing the FieldInfo. Probably this can be optimized a bunch. I haven't verified the performance implications at all.
Adds MaybeSerialize<T> which handles the reload nicely. Shows how to use it in FieldObject; it's very minimal changes to FieldObject to add this support. This is simpler than the proof of concept code.
|
|
lostmsu
reviewed
Oct 28, 2020
Comment on lines
+103
to
+105
| catch(SerializationException _) | ||
| { | ||
| } |
There was a problem hiding this comment.
What is the scenario when this could happen?
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This addresses multiple issues with domain reloading and changing the underlying serialized objects by Pythonnet (e.g.: removing/renaming a member, class, namespace,..)
This also adds isolated tests for domain reloading. Each test scenario is run in its own process.
Does this close any currently open issues?
This addresses #1250, and could also address part of #1268
Any other comments?
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG