8000 Select correct method to invoke when keyword arguments are used by danabr · Pull Request #1242 · pythonnet/pythonnet · GitHub
[go: up one dir, main page]
Skip to content

Select correct method to invoke when keyword arguments are used #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2020
Merged

Select correct method to invoke when keyword arguments are used #1242

merged 1 commit into from
Oct 1, 2020

Conversation

danabr
Copy link
Contributor
@danabr danabr commented Sep 30, 2020

What does this implement/fix? Explain your changes.

If there were two methods with the same name, but with different arity,
Foo(a) and Foo(a,b), and the latter was called with a keyword
argument some.Foo(0, b=1), Foo(0) would be called instead of
Foo(0,1).

Does this close any currently open issues?

Fixes #1235.

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • [] If an enhancement PR, please create docs and at best an example
  • [] Add yourself to AUTHORS
  • Updated the CHANGELOG

@danabr
Select correct method to invoke when keyword arguments are used
29fccdb 
If there were two methods with the same name, but with different arity,
`Foo(a)` and `Foo(a,b)`, and the latter was called with a keyword
argument `some.Foo(0, b=1)`, `Foo(0)` would be called instead of
`Foo(0,1)`.

Fixes pythonnet#1235.
@codecov-commenter
Copy link
codecov-commenter commented Sep 30, 2020 •
edited
Loading

Codecov Report

Merging #1242 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1242   +/-   ##
=======================================
  Coverage   86.25%   86.25%           
=======================================
  Files           1        1           
  Lines         291      291           
=======================================
  Hits          251      251           
  Misses         40       40
Flag Coverage Δ
#setup_linux 64.94% <ø> (ø)
#setup_windows 72.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5ba815...29fccdb. Read the comment docs.

filmor
filmor reviewed Oct 1, 2020
View reviewed changes
@filmor
Copy link
Member
filmor commented Oct 1, 2020

Great thanks :)

@filmor filmor merged commit d44f1da into pythonnet:master Oct 1, 2020
@danabr danabr mentioned this pull request Oct 21, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filmor filmor filmor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong method chosen if argument is passed as keyword argument
3 participants
@danabr @codecov-commenter @filmor
0