Add Format method to pythonexception #1031
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows formatting a PythonException using traceback.format_exception
lostmsu
requested changes
Jan 16, 2020
| } | ||
| catch (PythonException ex) | ||
| { | ||
| Assert.That(ex.Format(), Does.Contain("Traceback").And.Contains("(most recent call last):").And.Contains("ValueError: Error!")); |
There was a problem hiding this comment.
Not sure if Python exceptions messages are localized. If that is the case, you need to ensure the right locale is used before performing this test.
There was a problem hiding this comment.
I will try and figure out if exception messages are localized.
|
Not sure why the Travis CI build is not showing up, it is here: https://travis-ci.org/github/pythonnet/pythonnet/builds/672296231 |
lostmsu
approved these changes
Apr 8, 2020
AlexCatarino
pushed a commit
to QuantConnect/pythonnet
that referenced
this pull request
Jun 29, 2020
Allows formatting a PythonException using traceback.format_exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Adds a Format method to PythonException which calls traceback.format_exception to get a nice exception message similar to something you would see on the Python console.
Does this close any currently open issues?
No
Any other comments?
N/A
Checklist
Check all those that are applicable and complete.
AUTHORSCHANGELOG