8000 Remove unnecessary `CopySlot` calls(split from #958) by amos402 · Pull Request #1004 · pythonnet/pythonnet · GitHub
[go: up one dir, main page]
Skip to content

Remove unnecessary CopySlot calls(split from #958) #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 2, 2019
Merged

Remove unnecessary CopySlot calls(split from #958) #1004

merged 1 commit into from
Dec 2, 2019

Conversation

amos402
Copy link
Member
@amos402 amos402 commented Nov 30, 2019

What does this implement/fix? Explain your changes.

...

Does this close any currently open issues?

...

Any other comments?

...

Checklist

Check all those that are applicable and complete.

  • Make sure to include one or more tests for your change
  • If an enhancement PR, please create docs and at best an example
  • Add yourself to AUTHORS
  • Updated the CHANGELOG

@codecov-io
Copy link
codecov-io commented Nov 30, 2019 •
edited
Loading

Codecov Report

Merging #1004 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1004   +/-   ##
=======================================
  Coverage   86.71%   86.71%           
=======================================
  Files           1        1           
  Lines         301      301           
=======================================
  Hits          261      261           
  Misses         40       40
Flag Coverage Δ
#setup_linux 65.44% <ø> (ø) ⬆️
#setup_windows 71.42% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 34d8d35...7750765. Read the comment docs.

@filmor filmor merged commit d1044c3 into pythonnet:master Dec 2, 2019
AlexCatarino pushed a commit to QuantConnect/pythonnet that referenced this pull request Jun 27, 2020
@amos402 @AlexCatarino
Remove unnecessary CopySlot calls (pythonnet#1004)
b4d2e39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amos402 @codecov-io @filmor
0