Fix for CI: define NETSTANDARD in src/embed_tests

Benoit Hudson · Benoit Hudson · commit 13f8b539bdc0 · 2018-10-03T10:02:06.000-04:00
Also disable the domain reload test under either NETSTANDARD or NETCOREAPP (the
former was used in the runtime, the latter in embed_tests).
diff --git a/src/embed_tests/Python.EmbeddingTest.15.csproj b/src/embed_tests/Python.EmbeddingTest.15.csproj
@@ -29,6 +29,7 @@
     <BaseDefineConstants>XPLAT</BaseDefineConstants>
     <DefineConstants>$(DefineConstants);$(CustomDefineConstants);$(BaseDefineConstants);</DefineConstants>
     <DefineConstants Condition="'$(TargetFramework)'=='netcoreapp2.0'">$(DefineConstants);NETCOREAPP</DefineConstants>
+    <DefineConstants Condition="'$(TargetFramework)'=='netstandard2.0'">$(DefineConstants);NETSTANDARD</DefineConstants>
     <DefineConstants Condition="'$(BuildingInsideVisualStudio)' == 'true' AND '$(CustomDefineConstants)' != '' AND $(Configuration.Contains('Debug'))">$(DefineConstants);TRACE;DEBUG</DefineConstants>
     <FrameworkPathOverride Condition="'$(TargetFramework)'=='net40' AND $(Configuration.Contains('Mono'))">$(NuGetPackageRoot)\microsoft.targetingpack.netframework.v4.5\1.0.1\lib\net45\</FrameworkPathOverride>
   </PropertyGroup>
diff --git a/src/embed_tests/TestDomainReload.cs b/src/embed_tests/TestDomainReload.cs
@@ -6,12 +6,12 @@
 
 //
 // This test case is disabled on .NET Standard because it doesn't have all the
-// APIs we use; .NET Core doesn't implement application domains, which is what
-// we're testing so there's no point trying.
+// APIs we use. We could work around that, but .NET Core doesn't implement
+// domain creation, so it's not worth it.
 //
 // Unfortunately this means no continuous integration testing for this case.
 //
-#if !NETSTANDARD
+#if !NETSTANDARD && !NETCOREAPP
 namespace Python.EmbeddingTest
 {
     class TestDomainReload
