Disable app domain test case on .NET Standard

Benoit Hudson · Benoit Hudson · commit 9ab7b130813a · 2018-10-03T09:35:46.000-04:00
This test doesn't compile on appveyor and travis, because we use APIs from .NET
Framework 4.0 rather than .NET Standard. Even if it were fixed to compile, it
would throw exceptions because .NET Core doesn't have application domains.
diff --git a/src/embed_tests/TestDomainReload.cs b/src/embed_tests/TestDomainReload.cs
@@ -4,6 +4,14 @@
 using NUnit.Framework;
 using Python.Runtime;
 
+//
+// This test case is disabled on .NET Standard because it doesn't have all the
+// APIs we use; .NET Core doesn't implement application domains, which is what
+// we're testing so there's no point trying.
+//
+// Unfortunately this means no continuous integration testing for this case.
+//
+#if !NETSTANDARD
 namespace Python.EmbeddingTest
 {
     class TestDomainReload
@@ -228,3 +236,4 @@ static Assembly ResolveAssembly(object sender, ResolveEventArgs args)
         }
     }
 }
+#endif

Original file line number	Diff line number	Diff line change
`@@ -4,6 +4,14 @@`
`4`	`4`	`using NUnit.Framework;`
`5`	`5`	`using Python.Runtime;`
`6`	`6`
	`7`	`+//`
	`8`	`+// This test case is disabled on .NET Standard because it doesn't have all the`
	`9`	`+// APIs we use; .NET Core doesn't implement application domains, which is what`
	`10`	`+// we're testing so there's no point trying.`
	`11`	`+//`
	`12`	`+// Unfortunately this means no continuous integration testing for this case.`
	`13`	`+//`
	`14`	`+#if !NETSTANDARD`
`7`	`15`	`namespace Python.EmbeddingTest`
`8`	`16`	`{`
`9`	`17`	`class TestDomainReload`
`@@ -228,3 +236,4 @@ static Assembly ResolveAssembly(object sender, ResolveEventArgs args)`
`228`	`236`	`}`
`229`	`237`	`}`
`230`	`238`	`}`
	`239`	`+#endif`