GL example fixes #2718
Merged
GL example fixes #2718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
- Restore buffer rendering backend as default for spritelists
- Fix spritelist customization examples
There was a problem hiding this comment.
Pull Request Overview
This PR restores the buffer rendering backend as the default for SpriteLists and fixes various spritelist customization examples in OpenGL. Key updates include switching the default backend to SpriteListBufferData, updating shader inputs from vec3 to vec4, and correcting minor naming inconsistencies.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| arcade/sprite_list/sprite_list.py | Restores default backend by activating SpriteListBufferData and removing duplicate instantiation of SpriteListTextureData. |
| arcade/examples/gl/spritelist_interaction_visualize_dist_los_trans.py | Updates shader input type from vec3 to vec4 and accesses geometry via coins.data.geometry. |
| arcade/examples/gl/spritelist_interaction_visualize_dist_los.py | Similar shader input and geometry access updates as the previous shader example. |
| arcade/examples/gl/spritelist_interaction_visualize_dist.py | Updates shader input types and geometry rendering to use data.geometry. |
| arcade/examples/gl/spritelist_interaction_hijack_positions.py | Adds type checks, updates shader inputs to vec4, and fixes a spelling typo in a comment. |
| arcade/examples/gl/spritelist_interaction_bouncing_coins.py | Adjusts SpriteList instantiation and buffer description input names for consistency. |
Comments suppressed due to low confidence (2)
arcade/examples/gl/spritelist_interaction_hijack_positions.py:45
- The comment uses 'bendyness' which is a misspelling. Please update it to 'bendiness' to ensure consistent naming.
uniform float bend; // The "bendyness" value accelerating rotations
arcade/examples/gl/spritelist_interaction_bouncing_coins.py:36
- Switching from 'use_spatial_hash=None' to 'use_spatial_hash=False' clarifies the intended behavior; please ensure that any usage relying on the old default value is updated accordingly.
self.coins = arcade.SpriteList(use_spatial_hash=False)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.