8000 GL example fixes by einarf · Pull Request #2718 · pythonarcade/arcade · GitHub
[go: up one dir, main page]

Skip to content

GL example fixes #2718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 9, 2025
Merged

GL example fixes #2718

merged 5 commits into from
Jun 9, 2025

Conversation

einarf
Copy link
Member
@einarf einarf commented Jun 9, 2025
  • Restore buffer rendering backend as default for spritelists
  • Fix spritelist customization examples

@einarf einarf requested a review from Copilot June 9, 2025 10:29
Copy link
Contributor
@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR restores the buffer rendering backend as the default for SpriteLists and fixes various spritelist customization examples in OpenGL. Key updates include switching the default backend to SpriteListBufferData, updating shader inputs from vec3 to vec4, and correcting minor naming inconsistencies.

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
arcade/sprite_list/sprite_list.py Restores default backend by activating SpriteListBufferData and removing duplicate instantiation of SpriteListTextureData.
arcade/examples/gl/spritelist_interaction_visualize_dist_los_trans.py Updates shader input type from vec3 to vec4 and accesses geometry via coins.data.geometry.
arcade/examples/gl/spritelist_interaction_visualize_dist_los.py Similar shader input and geometry access updates as the previous shader example.
arcade/examples/gl/spritelist_interaction_visualize_dist.py Updates shader input types and geometry rendering to use data.geometry.
arcade/examples/gl/spritelist_interaction_hijack_positions.py Adds type checks, updates shader inputs to vec4, and fixes a spelling typo in a comment.
arcade/examples/gl/spritelist_interaction_bouncing_coins.py Adjusts SpriteList instantiation and buffer description input names for consistency.
Comments suppressed due to low confidence (2)

arcade/examples/gl/spritelist_interaction_hijack_positions.py:45

  • The comment uses 'bendyness' which is a misspelling. Please update it to 'bendiness' to ensure consistent naming.
uniform float bend;  // The "bendyness" value accelerating rotations

arcade/examples/gl/spritelist_interaction_bouncing_coins.py:36

  • Switching from 'use_spatial_hash=None' to 'use_spatial_hash=False' clarifies the intended behavior; please ensure that any usage relying on the old default value is updated accordingly.
self.coins = arcade.SpriteList(use_spatial_hash=False)

@einarf einarf merged commit c35f846 into development Jun 9, 2025
7 checks passed
@einarf einarf deleted the gl-example-tweaks branch June 9, 2025 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
0