attempt to support modern Python3 versions#276
Open
a-detiste wants to merge 2 commits intopython-xlib:masterfrom
Open
attempt to support modern Python3 versions#276a-detiste wants to merge 2 commits intopython-xlib:masterfrom
a-detiste wants to merge 2 commits intopython-xlib:masterfrom
Conversation
Avasam
suggested changes
Apr 11, 2025
Contributor
There was a problem hiding this comment.
Here's a few additional replacements you're still missing:
six.MAXSIZE > sys.maxsize
six.iterbytes > iter
six.moves._thread > _thread
six.byte2int > operator.itemgetter(0), or just access [0] directly
six.text_type > str Only used where it's already a str, so just remove
six.indexbytes > Access directly with []
six.create_unbound_method > Just use the function directly
Author
|
Thanks. I will réconciliate your tweaks with the one that ended up in the Debian patch https://sources.debian.org/src/python-xlib/0.33-3/debian/patches/remove_six.patch/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
python-xlib is today the top-most remaining user of
six. We slowly try to remove six from the distribution