Open
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #246 +/- ##
=======================================
Coverage 78.21% 78.21%
===
6880
====================================
Files 42 42
Lines 4705 4705
=======================================
Hits 3680 3680
Misses 1025 1025 |
Collaborator
|
Please resolve conflicts. |
Contributor
Author
|
@vasily-v-ryabov Conflicts has been resolved. Could I get a review on this? |
Contributor
Author
Updated type comparison to one that is understood by type-checkers - `is None` instead of `== None` - `set_cooler_manual_control_enabled` was comparing a bool agains `1`. Which would always return `False` - `getattr` instead of `hasattr` when applicable
855dd10 to
c962168
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getattrinstead ofhasattrwhen applicableisinstance(x)instead oftype(x) ==is Noneinstead of== Noneset_cooler_manual_control_enabledwas comparing a bool against1. Which is redundant.