Detect pyproject.toml as project root #371 8000
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Huh, I had no idea it was possible to use this outside setuptools. Would you mind contributing docs showing how to do this? @Callek Any interest in shepherding this one in? |
|
Only PDM (build-backend: pdm.backend) can read version by call function now (I'm not sure if hatchling works because it seem use regex to get the version). Config for pdm.backend included in the first comment. |
Callek
approved these changes
Jul 6, 2023
Comment on lines
64
to
+67
| # allow 'python path/to/setup.py COMMAND' | ||
| root = os.path.dirname(os.path.realpath(os.path.abspath(sys.argv[0]))) | ||
| setup_py = os.path.join(root, "setup.py") | ||
| pyproject_toml = os.path.join(root, "pyproject.toml") |
There was a problem hiding this comment.
I don't necessarily think doing the path translation is necessary here, but happy to keep it for consistency. (I actually suspect we should rewrite some of this logic a bit, since it defaults to cwd() rather than the actual target of the package.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes I use some package build tools which doesn't require setup.py, for example, pdm.backend. It doesn't need a setup.py, instead, it'll build wheel directly.
So with this pr, I can do this:
Then when I run
pdm build, pdm will read version from 'versioneer.get_version()'.However, this doesn't work now because versioneer requires setup.py or versioneer.py to detect project root. It cannot find project root without setup.py or versioneer.py. When I using build-time dependency mode and "setup.py-less" build backend, either setup.py or versioneer.py doesn't exist, but the project root is still here! So this pull request made versioneer able to detect project root by pyproject.toml.