MNT: Overwrite file instead of deleting/writing it #353
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7b3f395 to
942bae8
Compare
5a09e63 to
3ffc5f5
Compare
Why create a new inode? Overwrite the contents of the existing inode.
3ffc5f5 to
d4b6ce8
Compare
|
Was curious why it was this way. Seems like it was added on the second commit (2d60f55). The main thing I can think of would be that if there's a chance the file was linked/symlinked, you could end up with a file modified at a distance. Since this is happening in the build directory, a copy is most likely, so that danger seems low. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why create a new inode? Overwrite the contents of the existing inode.