8000 FIX: handle unset versionfile_build in build_ext by mgorny · Pull Request #347 · python-versioneer/python-versioneer · GitHub
[go: up one dir, main page]
Skip to content

FIX: handle unset versionfile_build in build_ext #347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2022
Merged

FIX: handle unset versionfile_build in build_ext #347

merged 1 commit into from
Oct 21, 2022

Conversation

mgorny
Copy link
Contributor
@mgorny mgorny commented Oct 21, 2022

Fix a crash due to attempting to pass None to os.path.join() when versionfile_build is not set in the config file, and build_ext command is called directly.

Fixes #346

@mgorny
FIX: handle unset versionfile_build in build_ext
d33dff3 
Fix a crash due to attempting to pass `None` to `os.path.join()`
when `versionfile_build` is not set in the config file, and `build_ext`
command is called directly.

Fixes python-versioneer#346
@effigies effigies merged commit 59dceed into python-versioneer:master Oct 21, 2022
@mgorny mgorny deleted the build-ext branch October 21, 2022 13:25
@mgorny
Copy link
Contributor Author
mgorny commented Oct 21, 2022

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setup.py build_ext: TypeError: join() argument must be str, bytes, or os.PathLike object, not 'NoneType'
2 participants
@mgorny @effigies
0