8000 CI: python-version should be a string, not a float by DimitriPapadopoulos · Pull Request #340 · python-versioneer/python-versioneer · GitHub
[go: up one dir, main page]
Skip to content

CI: python-version should be a string, not a float #340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2022
Merged

CI: python-version should be a string, not a float #340

merged 1 commit into from
Sep 26, 2022

Conversation

DimitriPapadopoulos
Copy link
Contributor

This shows clearly with '3.10' which is different from '3.1'.

@DimitriPapadopoulos
CI: python-version should be a string, not a float
957ebcb 
This shows clearly with '3.10' which is different from '3.1'.
@effigies
Copy link
Contributor

Have you found this causes problems in some situations?

@DimitriPapadopoulos
Copy link
Contributor Author

Yes, when a version ends with 0.

For documentation purposes, I feel it is better to use explicit strings. Otherwise, other maintainers may for example trigger this error when updating a version from 3.9 to 3.10.

@effigies
Copy link
Contributor

Fair enough.

@effigies effigies merged commit 44d07c5 into python-versioneer:master Sep 26, 2022
@DimitriPapadopoulos DimitriPapadopoulos deleted the python-version branch September 27, 2022 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @effigies
0