10000 Fix issue (?) found by codespell by DimitriPapadopoulos · Pull Request #266 · python-versioneer/python-versioneer · GitHub
[go: up one dir, main page]
Skip to content

Fix issue (?) found by codespell #266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2021
Merged

Fix issue (?) found by codespell #266

merged 2 commits into from
Sep 27, 2021

Conversation

DimitriPapadopoulos
Copy link
Contributor

codespell complains:

./NOTES:60: delink ==> unlink

@effigies
Copy link
Contributor

Reading this, I believe it means that the file should still exist, but shouldn't be a hardlink or symlink to another file. I think "unlink" was specifically avoided for this reason.

@DimitriPapadopoulos
Copy link
Contributor Author
DimitriPapadopoulos commented Sep 27, 2021 •
edited
Loading

I see. Should this perhaps be modified to something like the following?
make sure _version.py is not a symlink or hardlink before changing it

@effigies
Copy link
Contributor

Would codespell accept quotes around it, like "delink"? Or what about "break the link"?

@DimitriPapadopoulos
Copy link
Contributor Author
DimitriPapadopoulos commented Sep 27, 2021 •
edited
Loading

I think codespell doesn't take punctuation into account. In any case don't bother about codespell, I can add a config file to shut it up if needed (unfortunately tox.ini won't work so it'll be setup.cfg or .codespellrc but I have requested a change in codespell-project/codespell#2086).

@DimitriPapadopoulos
Copy link
Contributor Author

The question is whether "need to delink _version.py before changing it" should be clarified for humans - not for codespell.

effigies
effigies reviewed Sep 27, 2021
View reviewed changes
@effigies
Copy link
Contributor

Sure. Made a suggestion.

@DimitriPapadopoulos @effigies
Update NOTES
fbdd335 
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
@DimitriPapadopoulos
Copy link
Contributor Author

Perfect! Thank you.

@effigies effigies merged commit c4132a2 into python-versioneer:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DimitriPapadopoulos @effigies
0