8000 FIX: Respect versionfile_source in __init__.py snippet by staticintlucas · Pull Request #241 · python-versioneer/python-versioneer · GitHub
[go: up one dir, main page]
Skip to content

FIX: Respect versionfile_source in __init__.py snippet #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 20, 2021
Merged

FIX: Respect versionfile_source in __init__.py snippet #241

merged 3 commits into from
May 20, 2021

Conversation

staticintlucas
Copy link
Contributor
@staticintlucas staticintlucas commented Dec 21, 2020 •
edited
Loading

Fixes #123, fixes #218.

Now uses the correct module name from versionfile_source in the __init__.py snippet.

Since I was changing it anyway I also included the fix mentioned in #218. The snippet no longer deletes any object called get_versions in the root module.

@effigies
Copy link
Contributor

Thanks, and apologies for taking so long to get to this. Please have a look at https://github.com/staticintlucas/python-versioneer/pull/1. Note, I haven't tested either of these, yet...

@staticintlucas
Merge pull request #1 from effigies/enh/snippet_migration
e50d7a7 
ENH: Add migration path for new snippet
@staticintlucas
Copy link
Contributor Author

Those changes look good to me, I've merged your PR

@effigies effigies changed the title Fix __init__.py snippet to use correct _version.py module name FIX: Respect versionfile_source in __init__.py snippet May 20, 2021
@effigies
Copy link
Contributor

Thanks!

@effigies effigies merged commit 9f4cbca into python-versioneer:master May 20, 2021
@effigies effigies added this to the 0.20 milestone May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.20
2 participants
@staticintlucas @effigies
0