8000 Trio103: except Cancelled/BaseException must be re-raised by jakkdl · Pull Request #8 · python-trio/flake8-async · GitHub
[go: up one dir, main page]
Skip to content

Trio103: except Cancelled/BaseException must be re-raised #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 30, 2022
Merged

Trio103: except Cancelled/BaseException must be re-raised #8

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
d74e1fe
First draft of trio103, <Never have an except Cancelled or except Bas…
jakkdl Jul 27, 2022
a78429e
forgot to tox, still need to setup pre-commit hooks
jakkdl Jul 27, 2022
ad14b53
okay idk how I managed to push these failing tests
jakkdl Jul 27, 2022
327ad2b
ignore raises inside loops
jakkdl Jul 27, 2022
3d43d64
Merge remote-tracking branch 'origin/main' into trio103
jakkdl Jul 28, 2022
9ae8ce4
split 103 into 103+104, point to line+col of correct exception, accep…
jakkdl Jul 28, 2022
8eeb8f4
bare except with saved exception is acceptable
jakkdl Jul 28, 2022
88deb51
add visitor superclass, move down Visitor102
jakkdl Jul 28, 2022
17abc8a
merged main, fixed comments. Bare excepts are correctly handled, adde…
jakkdl Jul 29, 2022
077cd64
agh, it's confusing that the check returns OK and makes no indication…
jakkdl Jul 29, 2022
aae9482
update error message
jakkdl Jul 29, 2022
3e356ac
fix Trio100 bug, add test_messages_documented and test_trio_tests, cl…
jakkdl Jul 29, 2022
bcff826
Merge branch 'meta-tests' into trio103
jakkdl Jul 29, 2022
ebed2df
reorganize tests, various things, realize we need to handle continue/…
jakkdl Jul 29, 2022
e7dd585
pretty sure this is also an error
jakkdl Jul 29, 2022
8458fd5
fixed continue/break to escape except
jakkdl Jul 29, 2022
a41f00b
updated comments
jakkdl Jul 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
updated comments
  • Loading branch information
@jakkdl
jakkdl committed Jul 30, 2022
commit a41f00b92daff9d39ce6c52be5af0cb5a87ffdf2
4 changes: 2 additions & 2 deletions tests/test_flake8_trio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,10 @@ def test_trio103_104(self):
make_error(TRIO103, 47, 7),
make_error(TRIO103, 52, 7),
# nested exceptions
make_error(TRIO104, 67, 8), # weird case, unsure if error
make_error(TRIO104, 67, 8), # weird edge-case
make_error(TRIO103, 61, 7),
make_error(TRIO104, 92, 8),
# make_error(TRIO104, 94, 8), # TODO: not implemented
# make_error(TRIO104, 94, 8), # weird edge-case
# bare except
make_error(TRIO103, 97, 0),
# multi-line
Expand Down
6 changes: 3 additions & 3 deletions tests/trio103_104.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
except ValueError:
raise e
except:
raise e # error?
raise e # error: though sometimes okay
except BaseException: # safe
try:
pass
Expand All @@ -91,7 +91,7 @@
except ValueError as g:
raise g # error
except BaseException as h:
raise h # error ?
raise h # error? currently treated as safe
raise e
# bare except, equivalent to `except baseException`
except: # error
Expand Down Expand Up @@ -145,7 +145,7 @@ def foo():
return # error


# TODO: don't avoid re-raise with continue/break
# don't avoid re-raise with continue/break
while True:
try:
pass
Expand Down
0