start tagging releases again #385
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not necessarily, lightweight tags (not the ones GitHub makes for you) get marked as created at the same time as the commit they tag. |
Zac-HD
approved these changes
May 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#321 intended to move changelog/version checks to pre-commit, but it also removed tagging releases.. without reintroducing that anywhere else.
shoutout to @A5rocks for noticing
We could perhaps do the tagging in pre-commit as well, but that would require contributors to remember to push with
--tag.We could go back and "manually" create tags for all past releases since #321, but I'm not sure there's much reason to? But if it's to be done it should be done now before we start to create new tags