10000 Full Support for Bot API 9.1 by Bibo-Joshi · Pull Request #4847 · python-telegram-bot/python-telegram-bot · GitHub
[go: up one dir, main page]
Skip to content

Full Support for Bot API 9.1 #4847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Full Support for Bot API 9.1 #4847

wants to merge 11 commits into from

Conversation

Bibo-Joshi
Copy link
Member
@Bibo-Joshi Bibo-Joshi commented Jul 3, 2025 •
edited
Loading

When ready, closes #4845

Check-list for PRs

  • Added .. versionadded:: NEXT.VERSION, .. versionchanged:: NEXT.VERSION, .. deprecated:: NEXT.VERSION or ``.. versionremoved:: NEXT.VERSION` to the docstrings for user facing changes (for methods/class descriptions, arguments and attributes)
  • Created new or adapted existing unit tests
  • Documented code changes according to the CSI standard
  • Added myself alphabetically to AUTHORS.rst (optional)
  • Added new classes & modules to the docs and all suitable __all__ s
  • Checked the Stability Policy in case of deprecations or changes to documented behavior

If the PR contains API changes (otherwise, you can ignore this passage)

  • Checked the Bot API specific sections of the Stability Policy

  • Created a PR to remove functionality deprecated in the previous Bot API release (see here)

  • New Classes

    • Added self._id_attrs and corresponding documentation
    • __init__ accepts api_kwargs as keyword-only

  • Added New Shortcuts

    • In telegram.Chat & telegram.User for all methods that accept chat/user_id
    • In telegram.Message for all methods that accept chat_id and message_id
    • For new telegram.Message shortcuts: Added quote argument if methods accept reply_to_message_id
    • In telegram.CallbackQuery for all methods that accept either chat_id and message_id or inline_message_id

  • If Relevant

    • Added new constants at telegram.constants and shortcuts to them as class variables
    • Linked new and existing constants in docstrings instead of hard-coded numbers and strings
    • Added new message types to telegram.Message.effective_attachment
    • Added new handlers for new update types
    • Added new filters for new message (sub)types
    • Added or updated documentation for the changed class(es) and/or method(s)
    • Added the new method(s) to _extbot.py
    • Added or updated bot_methods.rst
    • Updated the Bot API version number in all places: README.rst (including the badge) and telegram.constants.BOT_API_VERSION_INFO
    • Added logic for arbitrary callback data in telegram.ext.ExtBot for new methods that either accept a reply_markup in some form or have a return type that is/contains telegram.Message

@Bibo-Joshi Bibo-Joshi added ⚙️ bot-api affected functionality: bot-api 🔌 enhancement pr description: enhancement labels Jul 3, 2025
@Bibo-Joshi Bibo-Joshi changed the title Api 9.1 Full Support for Bot API 9.1 Jul 3, 2025
@Bibo-Joshi Bibo-Joshi mentioned this pull request Jul 3, 2025
Open
16 tasks
aelkheir
aelkheir requested changes Jul 5, 2025
View reviewed changes
Copy link
Member
@aelkheir aelkheir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs mostly, regarding checklisttask commits.

tests/test_checklists.py
id=self.id + 1,
text=self.text,
)

Copy link
Member
@aelkheir aelkheir Jul 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
clt4 = Dice(5, "test")

or any other class :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added that in #4848. Sorry, I should have moved the commits to that PR :/

https://github.com/python-telegram-bot/python-telegram-bot/pull/4848/files#diff-01123289afd6b2ccd4e09084f7e571fa70e1c87547959e6a63e1d0f96b153680

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aelkheir aelkheir aelkheir requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
⚙️ bot-api affected functionality: bot-api 🔌 enhancement pr description: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Full Support for Bot API 9.1
3 participants
@Bibo-Joshi @aelkheir @harshil21
0