8000 Allow Input of Type `Sticker` for Several Methods by Bibo-Joshi · Pull Request #4616 · python-telegram-bot/python-telegram-bot · GitHub
[go: up one dir, main page]
Skip to content

Allow Input of Type Sticker for Several Methods #4616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 29, 2024
Merged

Allow Input of Type Sticker for Several Methods #4616

merged 7 commits into from
Dec 29, 2024

Conversation

Bibo-Joshi
Copy link
Member

Closes #4580
Adds convenience types for the methods that were shown by removing the obj.__name__.startswith("send") as explained in #4580.
Additional types can now follow more easily

@Bibo-Joshi Bibo-Joshi added ⚙️ tests affected functionality: tests 🔌 enhancement pr description: enhancement labels Dec 29, 2024
@codecov Codecov
Copy link
codecov bot commented Dec 29, 2024 •
edited
Loading

❌ 3 Tests Failed:

Tests completed Failed Passed Skipped
6379 3 6376 454
View the top 3 failed tests by shortest run time 
tests._files.test_animation.TestAnimationWithoutRequest::test_expected_values
Stack Traces | 0.003s run time 
self = <tests._files.test_animation.TestAnimationWithoutRequest object at 0x107b02590>
animation = Animation(api_kwargs={'thumb': {'file_id': 'AAMCBAADGQMAATM7i2dxnXsq1A-KJOBQ4X2sh98-X_k0AALgGQACToOIU1TznnOKN-3tAQAHcw...LgGQACToOIU1TznnOKN-3tAQAHcwADNgQ', file_size=2744, file_unique_id='AQAD4BkAAk6DiFN4', height=50, width=50), width=640)

    def test_expected_values(self, animation):
>       assert animation.mime_type == self.mime_type
E       AssertionError: assert 'image/gif' == 'video/mp4'
E         
E         - video/mp4
E         + image/gif

tests/_files/test_animation.py:69: AssertionError
tests._files.test_animation.TestAnimationWithRequest::test_send_animation_url_file
Stack Traces | 0.202s run time 
self = <tests._files.test_animation.TestAnimationWithRequest object at 0x107b48490>
bot = PytestExtBot[token=691423554:AAF8WkjCZbnHqP_i6GhTYirFElZrGaYOhX0]
chat_id = '675666224'
animation = <
8000
span class="pl-v">Animation(api_kwargs={'thumb': {'file_id': 'AAMCBAADGQMAATM7i2dxnXsq1A-KJOBQ4X2sh98-X_k0AALgGQACToOIU1TznnOKN-3tAQAHcw...LgGQACToOIU1TznnOKN-3tAQAHcwADNgQ', file_size=2744, file_unique_id='AQAD4BkAAk6DiFN4', height=50, width=50), width=640)

    async def test_send_animation_url_file(self, bot, chat_id, animation):
        message = await bot.send_animation(
            chat_id=chat_id, animation=self.animation_file_url, caption=self.caption
        )
    
        assert message.caption == self.caption
    
        assert isinstance(message.animation, Animation)
        assert isinstance(message.animation.file_id, str)
        assert isinstance(message.animation.file_unique_id, str)
        assert message.animation.file_id
        assert message.animation.file_unique_id
    
>       assert message.animation.duration == animation.duration
E       AssertionError: assert 1 == 0
E        +  where 1 = Animation(api_kwargs={'thumb': {'file_id': 'AAMCBAADGQMAATKwTGdQs6MnMc6HeB2UgY0Oo_e1LOHAAAI3AQACqsw9U2eu3Ij31bDXAQAHbQADNgQ', 'file_unique_id': 'AQADNwEAAqrMPVNy', 'file_size': 4451, 'width': 320, 'height': 180}}, duration=1, file_id='CgACAgQAAxkDAAEysExnULOjJzHOh3gdlIGNDqP3tSzhwAACNwEAAqrMPVNnrtyI99Ww1zYE', file_name='game.gif.mp4', file_size=4127, file_unique_id='AgADNwEAAqrMPVM', height=180, mime_type='video/mp4', thumbnail=PhotoSize(file_id='AAMCBAADGQMAATKwTGdQs6MnMc6HeB2UgY0Oo_e1LOHAAAI3AQACqsw9U2eu3Ij31bDXAQAHbQADNgQ', file_size=4451, file_unique_id='AQADNwEAAqrMPVNy', height=180, width=320), width=320).duration
E        +    where Animation(api_kwargs={'thumb': {'file_id': 'AAMCBAADGQMAATKwTGdQs6MnMc6HeB2UgY0Oo_e1LOHAAAI3AQACqsw9U2eu3Ij31bDXAQAHbQADNgQ', 'file_unique_id': 'AQADNwEAAqrMPVNy', 'file_size': 4451, 'width': 320, 'height': 180}}, duration=1, file_id='CgACAgQAAxkDAAEysExnULOjJzHOh3gdlIGNDqP3tSzhwAACNwEAAqrMPVNnrtyI99Ww1zYE', file_name='game.gif.mp4', file_size=4127, file_unique_id='AgADNwEAAqrMPVM', height=180, mime_type='video/mp4', thumbnail=PhotoSize(file_id='AAMCBAADGQMAATKwTGdQs6MnMc6HeB2UgY0Oo_e1LOHAAAI3AQACqsw9U2eu3Ij31bDXAQAHbQADNgQ', file_size=4451, file_unique_id='AQADNwEAAqrMPVNy', height=180, width=320), width=320) = Message(animation=Animation(api_kwargs={'thumb': {'file_id': 'AAMCBAADGQMAATKwTGdQs6MnMc6HeB2UgY0Oo_e1LOHAAAI3AQACqsw9U2eu3Ij31bDXAQAHbQADNgQ', 'file_unique_id': 'AQADNwEAAqrMPVNy', 'file_size': 4451, 'width': 320, 'height': 180}}, duration=1, file_id='CgACAgQAAxkDAAEysExnULOjJzHOh3gdlIGNDqP3tSzhwAACNwEAAqrMPVNnrtyI99Ww1zYE', file_name='game.gif.mp4', file_size=4127, file_unique_id='AgADNwEAAqrMPVM', height=180, mime_type='video/mp4', thumbnail=PhotoSize(file_id='AAMCBAADGQMAATKwTGdQs6MnMc6HeB2UgY0Oo_e1LOHAAAI3AQACqsw9U2eu3Ij31bDXAQAHbQADNgQ', file_size=4451, file_unique_id='AQADNwEAAqrMPVNy', height=180, width=320), width=320), caption='Test *animation*', channel_chat_created=False, chat=Chat(first_name='PTB', id=675666224, last_name='Test user', type=<ChatType.PRIVATE>), date=datetime.datetime(2024, 12, 29, 19, 5, 51, tzinfo=<UTC>), delete_chat_photo=False, document=Document(api_kwargs={'thumb': {'file_id': 'AAMCBAADGQMAATKwTGdQs6MnMc6HeB2UgY0Oo_e1LOHAAAI3AQACqsw9U2eu3Ij31bDXAQAHbQADNgQ', 'file_unique_id': 'AQADNwEAAqrMPVNy', 'file_size': 4451, 'width': 320, 'height': 180}}, file_id='CgACAgQAAxkDAAEysExnULOjJzHOh3gdlIGNDqP3tSzhwAACNwEAAqrMPVNnrtyI99Ww1zYE', file_name='game.gif.mp4', file_size=4127, file_unique_id='AgADNwEAAqrMPVM', mime_type='video/mp4', thumbnail=PhotoSize(file_id='AAMCBAADGQMAATKwTGdQs6MnMc6HeB2UgY0Oo_e1LOHAAAI3AQACqsw9U2eu3Ij31bDXAQAHbQADNgQ', file_size=4451, file_unique_id='AQADNwEAAqrMPVNy', height=180, width=320)), from_user=User(first_name='PTB tests on Travis using PyPy 2.7', id=691423554, is_bot=True, username='ptb_travis_pypy_27_bot'), group_chat_created=False, message_id=3357588, supergroup_chat_created=False).animation
E        +  and   0 = Animation(api_kwargs={'thumb': {'file_id': 'AAMCBAADGQMAATM7i2dxnXsq1A-KJOBQ4X2sh98-X_k0AALgGQACToOIU1TznnOKN-3tAQAHcwADNgQ', 'file_unique_id': 'AQAD4BkAAk6DiFN4', 'file_size': 2744, 'width': 50, 'height': 50}}, duration=0, file_id='CgACAgQAAxkDAAEzO4tncZ17KtQPiiTgUOF9rIffPl_5NAAC4BkAAk6DiFNU855zijft7TYE', file_name='game.gif', file_size=36535, file_unique_id='AgAD4BkAAk6DiFM', height=360, mime_type='image/gif', thumbnail=PhotoSize(file_id='AAMCBAADGQMAATM7i2dxnXsq1A-KJOBQ4X2sh98-X_k0AALgGQACToOIU1TznnOKN-3tAQAHcwADNgQ', file_size=2744, file_unique_id='AQAD4BkAAk6DiFN4', height=50, width=50), width=640).duration

tests/_files/test_animation.py:268: AssertionError
tests._files.test_animation.TestAnimationWithRequest::test_send_all_args
Stack Traces | 0.634s run time 
self = <tests._files.test_animation.TestAnimationWithRequest object at 0x107b03fa0>
bot = PytestExtBot[token=691423554:AAF8WkjCZbnHqP_i6GhTYirFElZrGaYOhX0]
chat_id = '675666224'
animation_file = <_io.BufferedReader name='.../tests/data/game.gif'>
animation = Animation(api_kwargs={'thumb': {'file_id': 'AAMCBAADGQMAATM7i2dxnXsq1A-KJOBQ4X2sh98-X_k0AALgGQACToOIU1TznnOKN-3tAQAHcw...LgGQACToOIU1TznnOKN-3tAQAHcwADNgQ', file_size=2744, file_unique_id='AQAD4BkAAk6DiFN4', height=50, width=50), width=640)
thumb_file = <_io.BufferedReader name='.../tests/data/thumb.jpg'>

    async def test_send_all_args(self, bot, chat_id, animation_file, animation, thumb_file):
        message = await bot.send_animation(
            chat_id,
            animation_file,
            duration=self.duration,
            width=self.width,
            height=self.height,
            caption=self.caption,
            parse_mode="Markdown",
            disable_notification=False,
            protect_content=True,
            thumbnail=thumb_file,
            has_spoiler=True,
            show_caption_above_media=True,
        )
    
        assert isinstance(message.animation, Animation)
        assert isinstance(message.animation.file_id, str)
        assert isinstance(message.animation.file_unique_id, str)
        assert message.animation.file_id
        assert message.animation.file_unique_id
>       assert message.animation.file_name == animation.file_name
E       AssertionError: assert 'game.gif.mp4' == 'game.gif'
E         
E         - game.gif
E         + game.gif.mp4
E         ?         ++++

tests/_files/test_animation.py:234: AssertionError

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

harshil21
harshil21 reviewed Dec 29, 2024
View reviewed changes
harshil21
harshil21 approved these changes Dec 29, 2024
View reviewed changes
Copy link
Member
@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Bibo-Joshi Bibo-Joshi merged commit a6cd9c5 into master Dec 29, 2024
26 checks passed
@Bibo-Joshi Bibo-Joshi deleted the more-convenience-types branch December 29, 2024 19:16
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harshil21 harshil21 harshil21 approved these changes

@Poolitzer Poolitzer Awaiting requested review from Poolitzer

Assignees
No one assigned
Labels
🔌 enhancement pr description: enhancement ⚙️ tests affected functionality: tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend Support for Convenience Types in Bot Methods
2 participants
@Bibo-Joshi @harshil21
0