feat: add show_caption_above_media parameter to (Ext)Defaults
#4520
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi. Thanks for your PR. There is no need to ping us. We will reply when we have the time. |
Bibo-Joshi
requested changes
Oct 21, 2024
There was a problem hiding this comment.
Hi. Please see my comments below. Also, be sure that you have read our contribution guide and include the check list in the PR description.
| @@ -114,6 +114,11 @@ async def main(): | |||
| do_quote(:obj:`bool`, optional): |reply_quote| | |||
|
|
|||
| .. versionadded:: 20.8 | |||
|
|
|||
| show_caption_above_media (:obj:`bool`, optional): Indicates whether the caption should be | |||
| shown above the media. Defaults to `None`. | |||
There was a problem hiding this comment.
Suggested change
| shown above the media. Defaults to `None`. | |
| shown above the media. Defaults to `None`. |
There was a problem hiding this comment.
this is not how we implement Defaults. Please have a look at the methods _insert_defaults and _insert_defaults_for_ilq_results. Note that changes will also be necessary for Bot. Finally, we will need new unit tests for this.
This comment was marked as spam.
This comment was marked as spam.
|
closing due to inactivity. @servusdei2018 feel free to reopen anytime if you want to continue working on this |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4306
Summary
This patch introduces a default setting for the
show_caption_above_mediaparameter in thetelegram.ext.Defaultsclass. This enhancement streamlines the process of setting this parameter across various bot methods that support it, such assend_video,send_photo, andedit_message_caption.Changes Made
show_caption_above_mediahas been added to the(Ext)Botclass.