Rename Testing Base Classes #4453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
|
Thanks! I ran (python-telegram-bot) ➜ python-telegram-bot git:(master) ✗ hyperfine "pytest --collect-only"
Benchmark 1: pytest --collect-only
Time (mean ± σ): 2.997 s ± 0.118 s [User: 2.897 s, System: 0.094 s]
Range (min … max): 2.928 s … 3.310 s 10 runs
Warning: Statistical outliers were detected. Consider re-running this benchmark on a quiet system without any interferences from other programs. It might help to use the '--warmup' or '--prepare' options.
(python-telegram-bot) ➜ python-telegram-bot git:(master) ✗ git checkout rename-test-classes
Switched to branch 'rename-test-classes'
Your branch is up to date with 'origin/rename-test-classes'.
(python-telegram-bot) ➜ python-telegram-bot git:(rename-test-classes) ✗ hyperfine "pytest --collect-only"
Benchmark 1: pytest --collect-only
Time (mean ± σ): 3.207 s ± 0.933 s [User: 3.107 s, System: 0.095 s]
Range (min … max): 2.888 s … 5.861 s 10 runs
Warning: The first benchmarking run for this command was significantly slower than the rest (5.861 s). This could be caused by (filesystem) caches that were not filled until after the first run. You should consider using the '--warmup' option to fill those caches before the actual benchmark. Alternatively, use the '--prepare' option to clear the caches before each timing run.My guess is that those classes are collected because they are being subclassed.. |
|
That means that you would prefer not to merge or that you agree with
? :) |
|
I agree we should we merge anyway, but was kinda hoping that there was a little speedup for collection. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses part sof #4324
Example console output before and after renaming:
Note that the number of collected items did not change. What did change is the elapsed time, however I'm not sure if this is really reproducable. In any case, it doesn't hurt to rename these classes and if on average it does speed up the collection that's a good thing :)