8000 feat: add the field `is_from_offline` to the class `Message` by mahdyar · Pull Request #4189 · python-telegram-bot/python-telegram-bot · GitHub
[go: up one dir, main page]
Skip to content

feat: add the field is_from_offline to the class Message #4189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 2, 2024
Merged

feat: add the field is_from_offline to the class Message #4189

merged 5 commits into from
Apr 2, 2024

Conversation

mahdyar
Copy link
Contributor
@mahdyar mahdyar commented Apr 2, 2024

No description provided.

@harshil21 harshil21 added the ⚙️ bot-api affected functionality: bot-api label Apr 2, 2024
harshil21
harshil21 requested changes Apr 2, 2024
View reviewed changes
Copy link
Member
@harshil21 harshil21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick pr!

@harshil21 harshil21 mentioned this pull request Apr 2, 2024
Closed
27 tasks
@mahdyar
Copy link
Contributor Author
mahdyar commented Apr 2, 2024

thanks for the quick pr!

Thx for the quick review! :)

@harshil21
Copy link
Member

One more thing - you also need to add an entry to constants.MessageType for the same field. And then make sure test_constants.py passes

@harshil21
Copy link
Member

One more thing - you also need to add an entry to constants.MessageType for the same field. And then make sure test_constants.py passes

Update: Apparently you shouldn't add it to constants. Instead add an ignore entry to that field in the test

@mahdyar
Copy link
Contributor Author
mahdyar commented Apr 2, 2024

One more thing - you also need to add an entry to constants.MessageType for the same field. And then make sure test_constants.py passes

Update: Apparently you shouldn't add it to constants. Instead add an ignore entry to that field in the test

Done.

@harshil21
Copy link
Member

Test failures are unrelated. Thanks for contributing!

@harshil21 harshil21 merged commit dcb471e into python-telegram-bot:api-7.2 Apr 2, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 10, 2024
< 68F2 input type="hidden" data-csrf="true" name="authenticity_token" value="tvAdDPK/t7iYKPteNJHaig+scx1QzLSs6HUTiAkJSdFMa1eYo5hut0/pCHbE9NdH0FnEYzAWnBPxr1KNFXinrw==" />
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@harshil21 harshil21 harshil21 requested changes

Assignees
No one assigned
Labels
⚙️ bot-api affected functionality: bot-api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahdyar @harshil21
0